Started Objective C compiler #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GreyCat
commented
Apr 27, 2019
jvm/src/test/scala/io/kaitai/struct/translators/TranslatorSpec.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/io/kaitai/struct/translators/BaseTranslator.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/io/kaitai/struct/translators/ObjcTranslator.scala
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,570 @@ | |||
| package io.kaitai.struct.languages | |||
|
|
|||
| import io.kaitai.struct.CppRuntimeConfig._ | |||
There was a problem hiding this comment.
Um, something tells me that ObjcCompiler should not use C++-specific config?
There was a problem hiding this comment.
I left that in there just in case I wanted some config options at a later point. I am now at a point where I am 99% sure I will not want any config options. So I will take it out.
| import io.kaitai.struct.datatype.DataType._ | ||
| import io.kaitai.struct.datatype.{CalcEndian, DataType, FixedEndian, InheritedEndian} | ||
| import io.kaitai.struct.exprlang.Ast | ||
| import io.kaitai.struct.exprlang.Ast.expr |
There was a problem hiding this comment.
Ideally, try to avoid importing this Ast.expr — we try to use Ast.expr directly (not expr, as it's too ambiguous) by convention.
| override def innerEnums = false | ||
|
|
||
| private def importListToStr(importList: ImportList): String = | ||
| importList.toList.map((x) => s"#import <$x>").mkString("", "\n", "\n") |
There was a problem hiding this comment.
Please indent this 2 spaces →.
| } | ||
|
|
||
| // Members declared in io.kaitai.struct.languages.components.EveryReadIsExpression | ||
| override def bytesPadTermExpr(expr0: String,padRight: Option[Int],terminator: Option[Int],include: Boolean): String = { |
There was a problem hiding this comment.
This def and below misses spaces after commas.
| outSrc.puts("// comment: attributeDeclaration: InstanceIdentifier or NamedIdentifier") | ||
|
|
||
| outHdr.puts(s"@property (strong,nonatomic) ${kaitaiType2NativeType(attrType, true)}${publicMemberName(attrName)};") | ||
| } |
There was a problem hiding this comment.
There is no need for { ... } block here.
…ith init are not supose to allocate objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: elaborate what exactly was changed and why