-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#252 - groups the public and private class members. #111
base: master
Are you sure you want to change the base?
Conversation
Note that I "abused" the ImportList for collecting the lines. I didn't want to create yet another class with the same functionality. |
About the bot warnings: I should probably declare them private. Also: It's still buggy: Comments (from "doc:") do not generate correctly. |
The comments bug comes from the fact that I only add unique lines - a mistake, when it comes to comment lines. Fixing that now... |
Alright. Fixed. I ended up not using the ImportList (instead using my own StringList class) and added a stack to properly manage the collector objects. |
I can't avoid the mutable warning, though. I have to change the |
I've reviewed this PR and I believe there are quite a few problems with it:
It its current state it's unlikely to be accepted. I'd suggest that we rework it using existing LanguageOutputWriter buffering classes: we have |
Makes the .h file neat and tidy :)