Create the MedusaConfiguration API #1180
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
- Coverage 57.19% 56.92% -0.27%
==========================================
Files 101 103 +2
Lines 10529 10526 -3
==========================================
- Hits 6022 5992 -30
- Misses 3980 4007 +27
Partials 527 527
|
| ) | ||
|
|
||
| // EDIT THIS FILE! THIS IS SCAFFOLDING FOR YOU TO OWN! | ||
| // NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized. |
There was a problem hiding this comment.
[nitpick] Can we remove those generated comments (here, in the spec below, and in the controller)? It makes it look like there's some unfinished work.
| } | ||
|
|
||
| configuration := instance.DeepCopy() | ||
| patch := client.MergeFrom(configuration.DeepCopy()) |
There was a problem hiding this comment.
[question] why call DeepCopy twice?
There was a problem hiding this comment.
The patch and the original object we're patching need to be in separate addresses for when we invoke .Status().Patch().
I'm not sure why we initially do a DeepCopy() on the object we get from the kube api, but I'm just following the convention we use elsewhere, which could be unnecessary but at least works fine :)
adejanovski
force-pushed
the
medusa-configuration-api
branch
from
c231e2a to
8af65ea
Compare
|
What this PR does:
Adds a MedusaConfiguration API.
Which issue(s) this PR fixes:
Fixes #1157
Checklist