Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize Reaper secrets names to gracefully handle cluster name overrides #1176

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

adejanovski
Copy link
Contributor

What this PR does:
What the title says, plus modify single dc reaper e2e tests to use an override.
Also renames the CreateSingleReaper subtest to CreateSingleReaperNoStargate, because running CreateSingleReaper  would also run CreateSingleReaperWStargateAndHTTP as it begins with the same string.

Which issue(s) this PR fixes:
Fixes #1002

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CHANGELOG.md updated (not required for documentation PRs)
  • CLA Signed: DataStax CLA

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
14.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dfcd0bf) 57.05% compared to head (d5dae29) 56.99%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   57.05%   56.99%   -0.06%     
==========================================
  Files         101      101              
  Lines       10437    10437              
==========================================
- Hits         5955     5949       -6     
- Misses       3961     3965       +4     
- Partials      521      523       +2     
Files Coverage Δ
pkg/reaper/secrets.go 4.34% <50.00%> (ø)

... and 2 files with indirect coverage changes

@adejanovski adejanovski marked this pull request as ready for review January 16, 2024 14:56
@adejanovski adejanovski requested a review from a team as a code owner January 16, 2024 14:56
@adejanovski adejanovski merged commit f96ea1c into main Jan 16, 2024
59 of 61 checks passed
@adejanovski
Copy link
Contributor Author

Thanks for the quick review @emerkle826 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reaper fails to deploy with some cluster names overrides
2 participants