Restrict the mutating webhook to cass-operator managed pods #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
+ Coverage 57.04% 57.08% +0.03%
==========================================
Files 101 101
Lines 10428 10428
==========================================
+ Hits 5949 5953 +4
+ Misses 3957 3956 -1
+ Partials 522 519 -3 |
|
burmanm
approved these changes
Jan 15, 2024
adejanovski
added a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Our mutating webhook currently breaks kubernetes clusters as soon as the k8ssandra-operator pod gets unresponsive or deleted.
This is because the webhook will stay registered and is currently mutating ALL pods in the cluster.
Instead we need to restrict it to pods created by cass-operator as they're the only ones we need to act upon.
This PR modifies the objectSelector to target pods with the
app.kubernetes.io/created-by: cass-operatorlabel only.Which issue(s) this PR fixes:
Fixes #1172
Checklist