Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lock generation in WORKSPACE #58

Merged
merged 16 commits into from
Dec 4, 2023
Merged

Support lock generation in WORKSPACE #58

merged 16 commits into from
Dec 4, 2023

Conversation

jvolkman
Copy link
Owner

@jvolkman jvolkman commented Dec 4, 2023

This adds pycross_pkg_repo, a repository rule that takes most of the same parameters as pycross_lock_file, pycross_pdm_lock_model, and pycross_poetry_lock_model, and generates a repo containing lock.bzl and all of the packages under //pkg.

The result is that a pycross lock.bzl file no longer needs to be committed/vended in the repository; all one needs is pyproject.toml and poetry.lock or pdm.lock and the lock generation happens automatically, similar to pip_install in rules_python.

This work is mostly a precursor to future bzlmod support.

Example:

load(
    "@jvolkman_rules_pycross//pycross:defs.bzl",
    "pkg_repo_model_pdm",
    "pycross_pkg_repo",
    "pycross_register_for_python_toolchains",
)

# assumes that a rules_python toolchain named "python" has been created.
pycross_register_for_python_toolchains(
    name = "pycross_toolchains",
    python_toolchains_repo_name = "python",
)

load("@pycross_toolchains//:defs.bzl", "environments")

pycross_pkg_repo(
    name = "pdm",
    default_alias_single_version = True,
    target_environments = environments,
    lock_model = pkg_repo_model_pdm(
        lock_file = "@//:pdm.lock",
        project_file = "@//:pyproject.toml",
    ),
)

load("@pdm//:defs.bzl", "install_deps")
install_deps()

and now, bazel build @pdm//:ipython or similar.

See examples/pkg_repo for a complete example.

@jvolkman jvolkman changed the title dev/repo rules Support lock generation in WORKSPACE Dec 4, 2023
@jvolkman jvolkman merged commit 0b39c22 into main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant