Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPython pygments lexers are moving to separate package #628

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

takluyver
Copy link
Member

See ipython/ipython#14520. The newly split package is already available now; I plan to leave the IPython.lib.lexers import working for a while, but I thought I'd update this while I'm thinking about it.

@takluyver
Copy link
Member Author

I'll probably extend the Python compatibility of the new package back some way. See also spyder-ide/spyder#23481

@takluyver
Copy link
Member Author

The Python 3.8 tests using conda are still failing. I've used conda-forge's python_min variable in ipython_pygments_kernels, so it's only available in conda-forge for Python >=3.9.

Should I look into if there's a way round that, or is it time for qtconsole to drop Python 3.8? Or to drop testing with conda on 3.8?

@ccordoba12 ccordoba12 added this to the 5.7.0 milestone Jan 21, 2025
@ccordoba12
Copy link
Collaborator

Should I look into if there's a way round that, or is it time for qtconsole to drop Python 3.8?

Don't worry about finding a workaround for that, I think it's not worth it. We can leave this to include it when we drop support for Python 3.8, as you said, in a few months.

Or you can give us a hand to leave a single Linux slot on CIs to test QtConsole with pip packages and remove the Windows and Mac ones. Sorry for not addressing that myself, but I'm a bit busy at the moment.

@takluyver
Copy link
Member Author

Thanks! I've removed the conda builds using Python 3.8 as you suggested, leaving the Linux + pip test jobs (pyqt5 & pyqt6) as the only remaining ones on 3.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants