Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Contribution Page for Jupyter Server #1499

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kjayan
Copy link

@kjayan kjayan commented Feb 10, 2025

The following updates are made to the contributing page .

  1. During building the docs, errors related to non availability of sphinx can happen. New instructions are added to install this package and its related dependencies
  2. Changed format for the line pip install hatch hatch run docs:build to reflect it properly
  3. Added double quotes which were missing for some commands like pip install ".[doc]" and pip install ".[test]"

@kjayan kjayan marked this pull request as draft February 10, 2025 16:18
@kjayan kjayan marked this pull request as ready for review February 11, 2025 05:05
@kjayan kjayan force-pushed the documentation-updates branch from 439abbe to d2fba9e Compare February 11, 2025 05:11
@kjayan kjayan force-pushed the documentation-updates branch from 9133eb2 to f1b7315 Compare February 11, 2025 11:14
pip install .[doc]
pip install ".[doc]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be docs instead of doc as per the dependency group defined in pyproject.toml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants