#51 Disable each file diff

junichi11 · May 1, 2018 · 9be78ae · 9be78ae
1 parent d66a30b
commit 9be78ae
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/src/main/java/com/junichi11/netbeans/modules/github/issues/issue/ui/FileChangedPanel.java b/src/main/java/com/junichi11/netbeans/modules/github/issues/issue/ui/FileChangedPanel.java
@@ -227,8 +227,8 @@ public void run() {
                         String mimeType = getMimeType(filename);
 
                         String prSha = file.getSha();
-                        StreamSource prSource = StreamSource.createSource(filename, prSha, mimeType, prReader); // NOI18N
-                        StreamSource baseSource = StreamSource.createSource(filename, baseSha, mimeType, baseReader); // NOI18N
+                        StreamSource prSource = StreamSource.createSource(filename, prSha, mimeType, prReader);
+                        StreamSource baseSource = StreamSource.createSource(filename, baseSha, mimeType, baseReader);
                         final DiffView view = Diff.getDefault().createDiff(baseSource, prSource);
                         SwingUtilities.invokeLater(new Runnable() {
                             @Override

diff --git a/src/main/java/com/junichi11/netbeans/modules/github/issues/issue/ui/GitHubIssuePanel.java b/src/main/java/com/junichi11/netbeans/modules/github/issues/issue/ui/GitHubIssuePanel.java
@@ -439,13 +439,15 @@ public void update() {
                     List<CommitFile> pullRequestsFiles = repository.getPullRequestsFiles(issue.getNumber());
                     filesChangedPanel.setDisplayName(String.format("[Diff] #%s - %s", id, summary)); // NOI18N
                     filesChangedPanel.removeAllFiles();
-                    String hostname = repository.getHostname();
-                    for (CommitFile file : pullRequestsFiles) {
-                        if (hostname.equals(GitHubIssues.DEFAULT_HOSTNAME)) {
-                            hostname = IGitHubConstants.HOST_DEFAULT;
-                        }
-                        filesChangedPanel.addFile(file, base, hostname);
-                    }
+                    // #51 disable each file diff
+                    // FIXME if we can get exact sha ids, this can be enabled again
+//                    String hostname = repository.getHostname();
+//                    for (CommitFile file : pullRequestsFiles) {
+//                        if (hostname.equals(GitHubIssues.DEFAULT_HOSTNAME)) {
+//                            hostname = IGitHubConstants.HOST_DEFAULT;
+//                        }
+//                        filesChangedPanel.addFile(file, base, hostname);
+//                    }
                     filesChangedPanel.setDetails(pullRequest);
                     filesChangedcollapsibleSectionPanel.setLabel(Bundle.GitHubIssuePanel_files_changed_count(pullRequestsFiles.size()));