Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Translate #1623

Merged
merged 1 commit into from
Jan 14, 2025
Merged

perf: Translate #1623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/elfinder/file_manager.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@
}
var kokoLang = getCookieByName("django_language");
if ( kokoLang.startsWith("en")) {
document.title = "File Manager"
document.title = "File explorer"
}else if (kokoLang.startsWith("ja")) {
document.title = "ファイル管理"
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be no apparent syntax errors, and there doesn't seem like any significant modifications. However, the content itself could potentially have some issues with consistency or style that need attention.

For example:

The use of "japanise" names ("file管理", "ファイル管理") instead of their correct English form is not very clear in context since it's unclear whether these are Japanese titles or translations into Japanese from another name. This might make the page less accessible due to cultural misunderstandings when visitors are used to other names for these operations.

Another issue related to the translation:

  • document.title = "File Explorer";
  • return render(request,"main.html");;
    It seems like you're returning a rendered 'main.html' file but this action isn't being taken anywhere later. It should either contain something like print/writeToFile() methods which handle displaying information based on the data fetched and stored elsewhere, or directly print the result back to the user interface.

As such, we can suggest making changes accordingly:

  1. Translation: Ensure all phrases match proper grammatical usage for clarity and accessibility. Make sure title strings accurately describe actions performed via the File Manager or Explorer.
  2. Documentation: Add comments where needed; they serve as important guides while learning how things work internally and externally alike.
  3. Return Values: Ensure functions return values meaningful enough for users to see at least the results of what was done. This includes rendering files, printing variables among others. The current code lacks concrete details about the intended outcomes unless explained further.

These adjustments would lead to a better UX/UI experience ensuring your documentation remains accessible even without direct feedback from developers working inside the program.

Expand Down
Loading