Merge pull request #44 from julia-vscode/fix-optimization-bug

Fix a bug in the swap optimization
julia-vscode · Jan 6, 2025 · 813a66b · 813a66b
2 parents 5d8b3a8 + 83e1d4e
commit 813a66b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/default_storage.jl b/src/default_storage.jl
@@ -245,6 +245,10 @@ function Salsa._memoized_lookup_internal(
                 # deps are recorded in-place. Note that we must swap them back at the end.
                 existing_value.dependencies, trace.ordered_deps =
                     trace.ordered_deps, existing_value.dependencies
+                # Because we are using the ordered_deps vector from the existing
+                # value, we need to empty it here, otherwise dependencies from a
+                # previous invocation of the derived function will hang around
+                empty!(trace.ordered_deps)
                 try
                     v = user_func(runtime, key.args...)
                 finally