Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type assert to *os.File never works for cacheFile #5615

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix type assert to *os.File never works for cacheFile #5615

wants to merge 2 commits into from

Conversation

polyrabbit
Copy link
Contributor

Once a struct is embedded in another struct, it can no longer be cast to the original one, therefore partial cached block are not deleted.

https://go.dev/play/p/nTPo6xRoyJO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@polyrabbit