Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop Node 4, 6, 8, 10, 12, 14 & 16 support #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Oct 28, 2024

As @ljharb mentioned in #114 (comment), he's open for a breaking change right now

if eslint forced a breaking change, at that time I’d reevaluate what we supported


BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0

BREAKING CHANGE: Requires Node@^18.18.0 || ^20.9.0 || >=21.1.0
@MichaelDeBoey
Copy link
Contributor Author

@ljharb Settings should be updated to make node 18+ required instead of node < 10 & node >= 10


on: [pull_request, push]

jobs:
tests:
uses: ljharb/actions/.github/workflows/node.yml@main
with:
range: '>= 10'
range: '^18.18.0 || ^20.9.0 || >=21.1.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 22 is out, so maybe don't need to support Node 21, which is unstable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've set node.engines to the same as ESLint is doing, but I'm happy to update if @ljharb wants to

@talentlessguy
Copy link

@MichaelDeBoey could you please update the node range to v22 so it's mergeable?

@ljharb
Copy link
Member

ljharb commented Jan 19, 2025

@talentlessguy that’s not what’s holding up this PR.

@talentlessguy
Copy link

@ljharb what's the problem then?

@ljharb
Copy link
Member

ljharb commented Jan 19, 2025

the PR is slightly premature. It won't be merged until all the breaking changes are ready, both here and in eslint-plugin-jsx-a11y.

@talentlessguy
Copy link

@ljharb which breaking changes should be ready? #142? or some other PR? shouldn't changes first be released in jsx-ast-utils to be incorporated in the updated jsx-a11y plugin?

@MichaelDeBoey
Copy link
Contributor Author

@ljharb This is the way you requested the PRs on the e18e Discord: add them in small PRs, so they can be reviewed easily

@ljharb
Copy link
Member

ljharb commented Jan 19, 2025

@MichaelDeBoey yep, and this is perfect once i'm ready :-) you don't need to do anything else.

@talentlessguy
Copy link

talentlessguy commented Jan 19, 2025

so in the end what kind of breaking changes have to be done in jsx-ast-utils? I still don't get it

@ljharb
Copy link
Member

ljharb commented Jan 19, 2025

@talentlessguy for one, I have to make a branch for the major bump, and re-base these PRs onto it, and then I can merge them into that branch. I'll also have to TS-type the whole package, and likely a few other things. But either way, it's not necessary for you to get it, you'll just have to be patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants