Merge branch 'master' into chore/improve-error-messages

.github/workflows/ci.yml

@@ -105,39 +105,50 @@ jobs:
         - name: Node.js 10.x
           node-version: "10.24"
           npm-i: [email protected]
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 11.x
           node-version: "11.15"
           npm-i: [email protected]
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 12.x
           node-version: "12.22"
           npm-i: [email protected]
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 13.x
           node-version: "13.14"
           npm-i: [email protected]
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 14.x
           node-version: "14.21"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 15.x
           node-version: "15.14"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 16.x
           node-version: "16.20"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 17.x
           node-version: "17.9"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 18.x
           node-version: "18.18"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 19.x
           node-version: "19.9"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 20.x
           node-version: "20.9"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 21.x
           node-version: "21.1"

benchmark/parse-top.js

@@ -22,26 +22,16 @@ Object.keys(top).forEach(function (domain) {
   })
 })
 
-suite.on('start', function onCycle (event) {
+suite.on('start', function () {
   process.stdout.write('  cookie.parse - top sites\n\n')
 })
 
-suite.on('cycle', function onCycle (event) {
+suite.on('cycle', function (event) {
   benchmarks.add(event.target)
 })
 
-suite.on('complete', function onComplete () {
+suite.on('complete', function () {
   benchmarks.log()
 })
 
-suite.run({async: false})
-
-function gencookies (num) {
-  var str = ''
-
-  for (var i = 0; i < num; i++) {
-    str += '; foo' + i + '=bar'
-  }
-
-  return str.slice(2)
-}
+suite.run({ async: false })

benchmark/parse-top.json

@@ -12,5 +12,6 @@
   "support.google.com": "UUU=000=l0llUUlUllU0UlllU0U0U0UlU-Ulll0lUlllU0UUllUUlUUUlllllUUUU-UUllUllU0lUU0U0U00lU0UUlUl0l0lUUlUUUUl0lUU0UUllUlUlUUlUlUUUU0ll0l0UU0lllU0lllUUUU0U0lU0U00l0Ul0UlU-U0UllU00lUUl0U; UUU=000=l0llUUlUllU0UlllU0U0U0UlU-Ulll0lUlllU0UUllUUlUUUlllllUUUU-UUllUllU0lUU0U0U00lU0UUlUl0l0lUUlUUUUl0lUU0UUllUlUlUUlUlUUUU0ll0l0UU0lllU0lllUUUU0U0lU0U00l0Ul0UlU-U0UllU00lUUl0U",
   "www.google.com": "0U_UUU=0000-00-00-00; UUU=Ullll0Ullll0U0llUllU00U_lllll0lUUlUl0UllUlUUl0lUlUUUl00UUl; UUU=000=lUU0U0U0U0UllUUUlUUlUUU_UlUll_l0U0UU00lUlUlUlllllUUUl00UllllUU_0ll0UllUllUUU-UUUlllU0UlUlUllUlUllUll00UllU0U00llUUl0lU00lUlUUlllUl_U00UUlU0UU0UllUlUU0lUUlUUUl00lUUlUUUU0ll",
   "youtu.be": "UUU=0; UUU=ll0UU-l0lUl; UUUUUUU_UUUU0_UUUU=0_llUUlUllU; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22",
-  "youtube.com": "UUU=0; UUU=l0_UlUUUlUl; UUUUUUU_UUUU0_UUUU=UUUUlUUUlll; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22"
+  "youtube.com": "UUU=0; UUU=l0_UlUUUlUl; UUUUUUU_UUUU0_UUUU=UUUUlUUUlll; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22",
+  "example.com": ""
 }

benchmark/parse.js

@@ -49,19 +49,19 @@ suite.add({
   fn: 'var val = cookie.parse(' + JSON.stringify(gencookies(100)) + ')'
 })
 
-suite.on('start', function onCycle (event) {
+suite.on('start', function () {
   process.stdout.write('  cookie.parse - generic\n\n')
 })
 
-suite.on('cycle', function onCycle (event) {
+suite.on('cycle', function (event) {
   benchmarks.add(event.target)
 })
 
 suite.on('complete', function onComplete () {
   benchmarks.log()
 })
 
-suite.run({async: false})
+suite.run({ async: false })
 
 function gencookies (num) {
   var str = ''