Robust position parser #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 90.66% 91.77% +1.11%
==========================================
Files 6 7 +1
Lines 857 961 +104
==========================================
+ Hits 777 882 +105
+ Misses 80 79 -1 ☔ View full report in Codecov by Sentry. |
phenylshima
force-pushed
the
robust-parser
branch
from
265cd3d to
f96e5fa
Compare
phenylshima
force-pushed
the
robust-parser
branch
from
f96e5fa to
94ca038
Compare
cm-ayf
reviewed
Jan 19, 2024
| EmptyRange, | ||
| } | ||
|
|
||
| pub fn estimate_position(input_pattern: &str) -> Result<(AllPosition, &str), PositionError> { |
There was a problem hiding this comment.
refactor……
letの初期化式が長くなってるのをそれぞれ関数に切り出す？
phenylshima
force-pushed
the
robust-parser
branch
from
0cbd3b1 to
dd686e2
Compare
phenylshima
force-pushed
the
robust-parser
branch
from
0a8330e to
aeee738
Compare
cm-ayf
reviewed
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split.match_position()はAllPositionを一意に決定し（もし複数の候補が残ればエラーを返します），split.verify(position)はそれが既知のパターンに矛盾しないことを確認します．したがって，パターンに記述された条件が不十分で一つに決定できない場合は
match_position，位置は一意に推定できるものの，文法が間違っていてマッチしないものはverifyでエラーになります．なお，
estimate_positionがOkを返したとしても，rangeが有効であること，及びrangeが有効に対象の範囲を絞り込めることは保証しません．例えば，*/B:?*は全くの無意味ですが，estimate_positionはOkを返します．