Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple Retry implementation #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

joeycumines
Copy link

I enjoy how simple Backoff is, but I found it surprisingly difficult to use it to correctly implement retry functionality.

This PR contains a single, very simple Retry implementation, that I've tried to style in the same vein as the existing code.

It is fully tested with examples, please take a look.

@joeycumines
Copy link
Author

@jpillora I did see you closed #12 for being too high level.

I feel like this approach provides excellent utility, still allowing arbitrary retry behavior. That is just IMO though, I am curious to see what you think.

Thanks for this implementation btw, I've used it many times now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant