[RFC] safe-mode #44765
Draft
[RFC] safe-mode #44765
+700
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
Language Change
richard67
reviewed
Jan 21, 2025
richard67
reviewed
Jan 21, 2025
administrator/components/com_admin/sql/updates/postgresql/5.3.0.2025-01.22.sql
Outdated
Show resolved
Hide resolved
|
@alikon nice work here. If I may I would like to propose another approach with less db stuff. We could use a reflection here to reset the plugins, in run time, similar to https://github.com/dgrammatiko/jailed-fs/blob/95444d8778e930a0360740e3b511b23bde374a5c/src/plugins/system/restrictedfs/src/Extension/RestrictedFS.php#L68-L78 You need to figure out what is essential and create the correct filter but should be an easier approach, ie not messing around with the real data in the db... Also, I would use a URL parameter, ie |
brianteeman
reviewed
Jan 22, 2025
Comment on lines
337
to
338
| <option value="0">COM_CONFIG_FIELD_DEBUG_SAFEMODEOFF</option> | ||
| <option value="1">COM_CONFIG_FIELD_DEBUG_SAFEMODEON</option> |
There was a problem hiding this comment.
Use the core language strings JOFF and JON
brianteeman
reviewed
Jan 22, 2025
| name="safemode" | ||
| type="radio" | ||
| label="COM_CONFIG_FIELD_DEBUG_SAFEMODE_LABEL" | ||
| description="COM_CONFIG_FIELD_DEBUG_SAFEMODE_DESC" |
There was a problem hiding this comment.
This string does not exist
brianteeman
reviewed
Jan 22, 2025
| ; Note : All ini files need to be saved as UTF-8 | ||
|
|
||
| PLG_SYSTEM_SAFEMODE="System - Joomla! SafeMode" | ||
| PLG_SYSTEM_SAFEMODE_DEFAULT_AUTHENTICATION_PLUGIN_NOT_ENABLED="The default authentication plugin is not enabled" |
There was a problem hiding this comment.
Suggested change
| PLG_SYSTEM_SAFEMODE_DEFAULT_AUTHENTICATION_PLUGIN_NOT_ENABLED="The default authentication plugin is not enabled" | |
| PLG_SYSTEM_SAFEMODE_DEFAULT_AUTHENTICATION_PLUGIN_NOT_ENABLED="The default authentication plugin is not enabled." |
brianteeman
reviewed
Jan 22, 2025
|
|
||
| PLG_SYSTEM_SAFEMODE="System - Joomla! SafeMode" | ||
| PLG_SYSTEM_SAFEMODE_DEFAULT_AUTHENTICATION_PLUGIN_NOT_ENABLED="The default authentication plugin is not enabled" | ||
| PLG_SYSTEM_SAFEMODE_OFF="Safe Mode is swithced off" |
There was a problem hiding this comment.
Suggested change
| PLG_SYSTEM_SAFEMODE_OFF="Safe Mode is swithced off" | |
| PLG_SYSTEM_SAFEMODE_OFF="Safe Mode is switched off." |
brianteeman
reviewed
Jan 22, 2025
| PLG_SYSTEM_SAFEMODE="System - Joomla! SafeMode" | ||
| PLG_SYSTEM_SAFEMODE_DEFAULT_AUTHENTICATION_PLUGIN_NOT_ENABLED="The default authentication plugin is not enabled" | ||
| PLG_SYSTEM_SAFEMODE_OFF="Safe Mode is swithced off" | ||
| PLG_SYSTEM_SAFEMODE_ON="Safe Mode is swithced on" |
There was a problem hiding this comment.
Suggested change
| PLG_SYSTEM_SAFEMODE_ON="Safe Mode is swithced on" | |
| PLG_SYSTEM_SAFEMODE_ON="Safe Mode is switched on." |
brianteeman
reviewed
Jan 22, 2025
| PLG_SYSTEM_SAFEMODE_DEFAULT_AUTHENTICATION_PLUGIN_NOT_ENABLED="The default authentication plugin is not enabled" | ||
| PLG_SYSTEM_SAFEMODE_OFF="Safe Mode is swithced off" | ||
| PLG_SYSTEM_SAFEMODE_ON="Safe Mode is swithced on" | ||
| PLG_SYSTEM_SAFEMODE_PUBLISH_NONCORE_WHEN_SAFEMODEON="You have published non-core extensions when Safe Mode is on" |
There was a problem hiding this comment.
Suggested change
| PLG_SYSTEM_SAFEMODE_PUBLISH_NONCORE_WHEN_SAFEMODEON="You have published non-core extensions when Safe Mode is on" | |
| PLG_SYSTEM_SAFEMODE_PUBLISH_NONCORE_WHEN_SAFEMODEON="You have published non-core extensions when Safe Mode is on." |
brianteeman
reviewed
Jan 22, 2025
| PLG_SYSTEM_SAFEMODE_OFF="Safe Mode is swithced off" | ||
| PLG_SYSTEM_SAFEMODE_ON="Safe Mode is swithced on" | ||
| PLG_SYSTEM_SAFEMODE_PUBLISH_NONCORE_WHEN_SAFEMODEON="You have published non-core extensions when Safe Mode is on" | ||
| PLG_SYSTEM_SAFEMODE_XML_DESCRIPTION="System Plugin that control the safe mode." |
There was a problem hiding this comment.
Suggested change
| PLG_SYSTEM_SAFEMODE_XML_DESCRIPTION="System Plugin that control the safe mode." | |
| PLG_SYSTEM_SAFEMODE_XML_DESCRIPTION="System Plugin that controls the safe mode." |
brianteeman
reviewed
Jan 22, 2025
| ; Note : All ini files need to be saved as UTF-8 | ||
|
|
||
| PLG_SYSTEM_SAFEMODE="System - Joomla! SafeMode" | ||
| PLG_SYSTEM_SAFEMODE_XML_DESCRIPTION="System Plugin that control the safe mode." |
There was a problem hiding this comment.
Suggested change
| PLG_SYSTEM_SAFEMODE_XML_DESCRIPTION="System Plugin that control the safe mode." | |
| PLG_SYSTEM_SAFEMODE_XML_DESCRIPTION="System Plugin that controls the safe mode." |
brianteeman
reviewed
Jan 22, 2025
plugins/system/safemode/safemode.xml
Outdated
| <name>plg_system_safemode</name> | ||
| <author>Joomla! Project</author> | ||
| <creationDate>2025-01</creationDate> | ||
| <copyright>(C) 2021 Open Source Matters, Inc.</copyright> |
There was a problem hiding this comment.
Suggested change
| <copyright>(C) 2021 Open Source Matters, Inc.</copyright> | |
| <copyright>(C) 2025 Open Source Matters, Inc.</copyright> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC Pull Request for Issue #44643 .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed