Globalcheckin task plugin error #44727 #44762
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This edit, allows the globalcheckin plugin task to work with 3rd party plugins that use "NOT NULL" in the checkout_out column. The previous code only half catered for this case and resulted in -2 error code when run. Note the behaviour of the scheduled globalcheckin task is inconsistent with a global checkin done from the admin control panel which works ok with "nut null". See joomla#44727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This edit, allows the globalcheckin plugin task to work with 3rd party plugins that use "NOT NULL" in the checkout_out column.
The previous code only half catered for this case and resulted in -2 error code when run.
Note the behaviour of the scheduled globalcheckin task is inconsistent with a global checkin done from the admin control panel which works ok with "nut null".
See #44727
Pull Request for Issue # .
Summary of Changes
This edit, allows the globalcheckin plugin task to work with 3rd party plugins that use "NOT NULL" in the checkout_out column.
The previous code only half catered for this case and resulted in -2 error code when run.
Note the behaviour of the scheduled globalcheckin task is inconsistent with a global checkin done from the admin control panel which works ok with "nut null".
See #44727
Testing Instructions
Have a prefixed table with the checked_out column with NULL not allowed.
Have the globalcheckin task enabled and running on a schedule
Do some backend admin to checkout an item from this table and leave it checked out for long enough for globalcheckin to be triggered on it.
Actual result BEFORE applying this Pull Request
The task returns error code -2, resulting in task failure email if configured to send emails on failure.
The item remains checked out
Expected result AFTER applying this Pull Request
The "item" is checked in by the scheduled task.
Link to documentations
Please select: