-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Deprecate namespace property of ComponentRecord #44754
Open
Fedik
wants to merge
3
commits into
joomla:5.3-dev
Choose a base branch
from
Fedik:deprecated-ns-prop
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have tested this item ✅ successfully on 74d0212 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44754. |
1 similar comment
I have tested this item ✅ successfully on 74d0212 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44754. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44754. |
@Fedik can you document it as well? |
laoneo
reviewed
Jan 20, 2025
Co-authored-by: Allon Moritz <[email protected]>
laoneo
added
the
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
label
Jan 22, 2025
Needs a manual entry before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
PR-5.3-dev
RTC
This Pull Request is Ready To Commit
Updates Requested
Indicates that this pull request needs an update from the author and should not be tested.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44737 .
Summary of Changes
The property were never initialised.
Probably left over from j4 development.
Testing Instructions
Code review
Link to documentations
Please select: