Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Deprecate namespace property of ComponentRecord #44754

Open
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jan 19, 2025

Pull Request for Issue #44737 .

Summary of Changes

The property were never initialised.
Probably left over from j4 development.

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@laoneo
Copy link
Member

laoneo commented Jan 20, 2025

I have tested this item ✅ successfully on 74d0212


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44754.

1 similar comment
@HLeithner
Copy link
Member

I have tested this item ✅ successfully on 74d0212


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44754.

@laoneo
Copy link
Member

laoneo commented Jan 20, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44754.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 20, 2025
@laoneo
Copy link
Member

laoneo commented Jan 20, 2025

@Fedik can you document it as well?

@laoneo laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jan 22, 2025
@laoneo
Copy link
Member

laoneo commented Jan 22, 2025

Needs a manual entry before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RTC This Pull Request is Ready To Commit Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants