Skip to content

Commit

Permalink
Add some phrases that were flagged negative (#123)
Browse files Browse the repository at this point in the history
Fixes: #120
  • Loading branch information
jonathanpeppers authored Dec 2, 2022
1 parent 3713b01 commit f61ad97
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
15 changes: 14 additions & 1 deletion comments/classified.csv
Original file line number Diff line number Diff line change
Expand Up @@ -4866,6 +4866,8 @@ No text is stored anywhere,0,0.5
Are customers wanting to be successful a bigger % of the time,0,0.5
This is talking about,0,0.5
We are here to talk about,0,0.5
Let's talk about,0,0.5
This is one issue to talk about,0,0.5
Why do you need #code?,0,0.5
I would not recommend using LinkAll here,0,0.5
"I know #code is archived/readonly, hopefully you are able to work on your own fork?",0,0.5
Expand Down Expand Up @@ -4911,4 +4913,15 @@ We just left the changes in,0,0.5
"Currently with the stress tests we have removing these caches wouldn't be a problem. However, we don't have a proof that our current simplification rules always avoid these worst-cases. There might be hope for removing some of these caches with future work on the theory side",0,0.5
"I haven't measured, but it's my understanding that in the worst case (when headers+body) happen to fit in a single TCP packet, you'll need an extra call to #code to schedule another IOCP callback",0,0.5
Ughhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh,1,0.5

How did you end up with #code,0,0.5
How did we end up with:,0,0.5
"Hmm, did we end up with:",0,0.5
"Whoops, did we end up with:",0,0.5
"Whoops, did we end up with: #code",0,0.5
#code is hitting this issue:,0,0.5
hitting this problem:,0,0.5
This is hitting: #code,0,0.5
hitting:,0,0.5
When your code gets here,0,0.5
When you're this good,0,0.5
#code has,0,0.5
18 changes: 17 additions & 1 deletion onnxjs/tests/test_cases.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@
"isnegative": "0"
},
{
"text": "You're giving us issues",
"text": "You're causing us issues",
"isnegative": "1"
},
{
Expand Down Expand Up @@ -383,5 +383,21 @@
{
"text": "It didn't hurt anything, so we just left it.",
"isnegative": "0"
},
{
"text": "Hmm, how did you end up with:",
"isnegative": "0"
},
{
"text": "This is hitting:",
"isnegative": "0"
},
{
"text": "When your",
"isnegative": "0"
},
{
"text": "`YourClass.YourType` has:",
"isnegative": "0"
}
]

0 comments on commit f61ad97

Please sign in to comment.