-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3919 & improve routing #15446
base: master
Are you sure you want to change the base?
Conversation
Hi, thanks for your contribution! |
This change will break the redirection to close3.html for everyone. |
Hey
Yea yea, i too noticed it being used in another place and plan to fix it
there as well. Thanks again for pointing it out
…On Sun, Jan 5, 2025, 5:46 AM Дамян Минков ***@***.***> wrote:
This change will break the redirection to close3.html for everyone.
—
Reply to this email directly, view it on GitHub
<#15446 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZHAGG6XVRLR4Y2M4ZD4GK32JB2WRAVCNFSM6AAAAABUTIGV2GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZRGQ2DQOBQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
No, you cannot change the path and require backend changes(webserver configuration), as those that have installed it via Debian packages will not have that change and that will stop working for them. |
Just do not change the path of the files. |
hey,
the close3.html will still be acessible right cuz all the files in static are served as it and we arent restricting any of them, i have used another route which aliases to tht file
change path of the file like as in changing the actual path of the file? idts i am modifying it anywhere |
No, it is no longer accessible after your change, as it is behind a path |
Pull Request Description
This PR implements one bug fix (#3919) and one enhancement:
Bug Fix:
Feature Improvement:
Please review the changes and let me know if you have any questions or feedback!