Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3919 & improve routing #15446

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohit-nagaraj
Copy link

@mohit-nagaraj mohit-nagaraj commented Jan 4, 2025

Pull Request Description

This PR implements one bug fix (#3919) and one enhancement:

Bug Fix:

  • Issue: Resolved the navigation issue when accessing specific routes.
  • Resolution: Ensured smooth navigation by addressing the underlying cause of the routing problem.

Feature Improvement:

  • Enhancement: Improved the "Close Meeting" functionality.
  • Details: Removed the reliance on direct HTML links, streamlining the process and making it more user-friendly.

Please review the changes and let me know if you have any questions or feedback!

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@damencho
Copy link
Member

damencho commented Jan 5, 2025

This change will break the redirection to close3.html for everyone.

@mohit-nagaraj
Copy link
Author

mohit-nagaraj commented Jan 5, 2025 via email

@damencho
Copy link
Member

damencho commented Jan 5, 2025

No, you cannot change the path and require backend changes(webserver configuration), as those that have installed it via Debian packages will not have that change and that will stop working for them.

@damencho
Copy link
Member

damencho commented Jan 5, 2025

Just do not change the path of the files.

@mohit-nagaraj
Copy link
Author

mohit-nagaraj commented Jan 5, 2025

hey,
I have a few things to ask you out

as those that have installed it via Debian packages will not have that change and that will stop working for them

the close3.html will still be acessible right cuz all the files in static are served as it and we arent restricting any of them, i have used another route which aliases to tht file

Just do not change the path of the files.

change path of the file like as in changing the actual path of the file? idts i am modifying it anywhere

@damencho
Copy link
Member

damencho commented Jan 5, 2025

the close3.html will still be acessible right cuz all the files in static are served as it and we arent restricting any of them

No, it is no longer accessible after your change, as it is behind a path /close and none of the existing deployments will match this path to close3.html file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants