Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_target() function in Chapter 9 #256

Closed
wants to merge 1 commit into from
Closed

Fix test_target() function in Chapter 9 #256

wants to merge 1 commit into from

Conversation

shaavan
Copy link

@shaavan shaavan commented Oct 17, 2022

  • The test target function should ideally check for if the bits_to_target function is correctly implemented or not.
  • However, it also checks for implementation of the difficulty function, which is the subsequent exercise of the chapter, and has a dedicated test for it.
  • This PR fixes that inconsistency.

@shaavan
Fix test_target() function in Chapter 9
744a8ae 
- The test target function should ideally check for if the
  bits_to_target function is correctly implemented or not.
- However, it actually checks for implementation of difficulty function
  as well which is the next exercise of the chapter and has a dedicated
  test for it.
- This commit fixes that inconsistency.
@shaavan shaavan closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shaavan