Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handshake code example, updating answer and comments. #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chanhosuh
Copy link
Contributor

Address issue #143:

  • fix boolean condition in example code
  • remove extra verack send
  • update answer accordingly
  • update handshake method comments

@chanhosuh chanhosuh force-pushed the chapter-10-handshake-fix branch from f60186d to b66fb8d Compare June 30, 2019 22:56
@xamevou
Copy link

xamevou commented Mar 7, 2021

Hi. I still receive an error, because there is no 'parse' for 'VersionMessage'. The error happens whenever I try the lines in pg. 183 and the solution to the 'handshake' exercise. The error happens after I updated both pieces of code, according to the fix explained here.

This is the error:
AttributeError: type object 'VersionMessage' has no attribute 'parse'

The solution, of course, is to implement the 'parse' method for 'VersionMessage'. Strangely, the method does not figure in the source code or in the book.

I am writing that parse method right now and things seem to work finally.

@0xtrr
Copy link

0xtrr commented Jan 23, 2022

Hi. I still receive an error, because there is no 'parse' for 'VersionMessage'. The error happens whenever I try the lines in pg. 183 and the solution to the 'handshake' exercise. The error happens after I updated both pieces of code, according to the fix explained here.

Here is an example of the parse method for VersionMessage: #143 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants