-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #167 and issue #165 #259
Open
Ivy987
wants to merge
12
commits into
jfree:master
Choose a base branch
from
Ivy987:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+146
−25
Open
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
79ae149
Issue 167 fixed
Ivy987 aa64d50
Update Issues167.java
Ivy987 b26c521
Update Issues167.java
Ivy987 ebda817
Update issues165.java
Ivy987 15a0f61
Update issues165.java
Ivy987 105ed55
Fixed issue #165
Ivy987 0fde0e3
Update issues165.java
Ivy987 9fd0405
Update issues165.java
Ivy987 4f71829
Update PiePlot.java
Ivy987 65ad815
Fixed issue #167
Ivy987 e701c53
Fixed issue #167, and issue #165
Ivy987 82e59cb
Update SpreadsheetDate.java
Ivy987 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package org.jfree.issues.issues165; | ||
|
|
||
| import org.jfree.data.time.Day; | ||
| import org.junit.jupiter.api.Assertions; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** | ||
| * Project: Issues165 | ||
| * Description: This file fixed the issue #165 for the jfree library. | ||
| * | ||
| * <p> | ||
| * author:wm | ||
| * Date:2021/12/8 | ||
| * Time:13:17 | ||
| * Version: | ||
| */ | ||
| public class issues165 { | ||
|
|
||
| @Test | ||
| //create a test for the year before 1990 | ||
| public void testOldCode() { | ||
| try { | ||
| org.jfree.data.time.Day day = new org.jfree.data.time.Day(1, 1, 1890); | ||
| }catch (Exception e){ | ||
| Assertions.assertEquals(e.getClass(),IllegalArgumentException.class); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| //test the year of 1700 | ||
| public void testSucessCode() { | ||
| Day day = new Day(1, 1, 1700); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package org.jfree.issues.issues167; | ||
|
|
||
| import org.jfree.chart.ChartFactory; | ||
| import org.jfree.chart.JFreeChart; | ||
| import org.jfree.chart.plot.pie.PiePlot; | ||
| import org.jfree.chart.swing.ChartFrame; | ||
| import org.jfree.data.general.DefaultPieDataset; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| /** | ||
| * Project: Issues167 | ||
| * Description: This file fixed the issue #167 for the jfree library. | ||
| * | ||
| * <p> | ||
| * author:wm | ||
| * Date:2021/11/18 | ||
| * Time:17:17 | ||
| * Version: | ||
| */ | ||
| public class Issues167 { | ||
|
|
||
| @Test | ||
| public void test1() throws InterruptedException { | ||
| //create the default pie chart | ||
| DefaultPieDataset ds = new DefaultPieDataset(); | ||
| ds.setValue("test01", 2); | ||
| ds.setValue("test02", 3); | ||
| ds.setValue("test03", 40); | ||
| ds.setValue("test04", 15); | ||
| ds.setValue("test05", 20); | ||
| ds.setValue("test06", 20); | ||
|
|
||
| //set the parameters, including title, dataset, legend, tooltips, urls. | ||
| JFreeChart chart = ChartFactory.createPieChart("", ds, true, true, false); | ||
| //Pie plot information | ||
| PiePlot pieplot = (PiePlot) chart.getPlot(); | ||
| pieplot.setSimpleLabels(true); | ||
|
|
||
| // set the title of the frame | ||
| ChartFrame chartFrame = new ChartFrame("", chart); | ||
| chartFrame.pack(); | ||
| chartFrame.setVisible(true); | ||
| Thread.sleep(5000); | ||
| } | ||
|
|
||
| @Test | ||
| public void test2() throws InterruptedException { | ||
| //create the default pie chart | ||
| DefaultPieDataset ds = new DefaultPieDataset(); | ||
| ds.setValue("test01", 2); | ||
| ds.setValue("test02", 3); | ||
| ds.setValue("test03", 80); | ||
| ds.setValue("test04", 15); | ||
|
|
||
|
|
||
| //set the parameters, including title, dataset, legend, tooltips, urls. | ||
| JFreeChart chart = ChartFactory.createPieChart("", ds, true, true, false); | ||
| //Pie plot information | ||
| PiePlot pieplot = (PiePlot) chart.getPlot(); | ||
| pieplot.setSimpleLabels(true); | ||
|
|
||
| //set the title of the frame | ||
| ChartFrame chartFrame = new ChartFrame("", chart); | ||
| chartFrame.pack(); | ||
| chartFrame.setVisible(true); | ||
| Thread.sleep(5000); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Just remove the last sentence (starting on line 43 and ending on 44) - then no need for adding lines 45 and 46.