Fix extensions (BuilderIO#992)

* fix extensions * remove log
jesse-forked · Jan 20, 2023 · f3652f7 · f3652f7
1 parent c6b0946
commit f3652f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/cli/src/build/helpers/extensions.ts b/packages/cli/src/build/helpers/extensions.ts
@@ -28,16 +28,17 @@ export const getFileExtensionForTarget = ({
       return '.ts';
     case 'lit':
       return '.ts';
+
+    // all JSX frameworks
     case 'solid':
     case 'qwik':
-      return isTs && type === 'filename' ? '.tsx' : '.jsx';
     case 'react':
     case 'reactNative':
     case 'rsc':
       switch (type) {
-        // we can't have `.jsx`/`.tsx` extensions in the import paths.
         case 'import':
-          return isTs ? '.ts' : '.js';
+          // we can't have `.jsx`/`.tsx` extensions in the import paths, so we stick with implicit file extensions.
+          return '';
         case 'filename':
           return isTs ? '.tsx' : '.jsx';
       }

diff --git a/packages/core/src/helpers/replace-identifiers.test.ts b/packages/core/src/helpers/replace-identifiers.test.ts
@@ -61,10 +61,7 @@ const TEST_SPECS: Spec[] = [
     const bar = foo;
     `,
     from: ['foo', 'test'],
-    to: (name) => {
-      console.log({ name });
-      return `${name}.value`;
-    },
+    to: (name) => `${name}.value`,
   },
 ];