Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to suppress merge commits diff in showRevision #1250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rscurciel
Copy link

@rscurciel rscurciel commented Jan 28, 2025

I create this PR to fix the issues mentioned in the PR#750.
The code changes are basically the same that in the closed PR but adding tests (thanks @anatoly-spb).

The issues are

The goal of this pull request is to add the option to suppress merge commits diff in the showRevision methods, the feature is disabled by default to maintain backward compatibility.

I plan to create a pull request in the git plugin too to add the option to use this configuration in the Polling ignores commits in certain paths extension once this is merged.

Testing done

I've run all the unit test and the steps specified in the Contributing document.
I've also tested it in Jenkins with git plugin installed too.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@rscurciel rscurciel requested a review from a team as a code owner January 28, 2025 11:42
@github-actions github-actions bot added the tests Automated test addition or improvement label Jan 28, 2025
@MarkEWaite MarkEWaite added enhancement Improvement or new feature and removed tests Automated test addition or improvement labels Feb 10, 2025
@rscurciel
Copy link
Author

Hi @MarkEWaite I just wanted to check if there's anything else I could do to help move this forward. Let me know if any further change are needed.

Thanks!.

@MarkEWaite
Copy link
Contributor

Hi @MarkEWaite I just wanted to check if there's anything else I could do to help move this forward. Let me know if any further change are needed.

Thanks!.

Thanks for asking. I'm working on other topics that are higher priority for me right now. It will likely be several weeks before I can look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants