-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code formatting for changed files #256
base: master
Are you sure you want to change the base?
Conversation
@@ -167,6 +167,31 @@ | |||
</archive> | |||
</configuration> | |||
</plugin> | |||
<plugin> | |||
<groupId>com.diffplug.spotless</groupId> | |||
<artifactId>spotless-maven-plugin</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Maybe we can add some instructions to the README file? Do we need to add some rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can do that. I was thinking for now it can be just for the files changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note in CONTRIBUTING.md
!
Needs rebasing |
Thanks, updated! |
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
What does this PR do?
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/
label attached. If applicable it should have thebackward-incompatible
label attached.do-not-merge/
label attached.kind/
andseverity/
labels attached at least.