Fix maven repositories http #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #43 Implement the remediation function for `MAVEN_REPOSITORIES_HTTP` to replace 'http' with 'https' in repository URLs. * Modify `plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/model/PreconditionError.java` to include the remediation function that uses `PomModifier` to replace 'http' with 'https' in repository URLs. * Add a method `replaceHttpWithHttps` in `plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/utils/PomModifier.java` to replace 'http' with 'https' in repository URLs. * Add tests in `plugin-modernizer-core/src/test/java/io/jenkins/tools/pluginmodernizer/core/extractor/MetadataCollectorTest.java` to verify the functionality of the remediation function for `MAVEN_REPOSITORIES_HTTP`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/43?shareId=XXXX-XXXX-XXXX-XXXX).
Fix maven repositories http issue
…fierTest.java Fixes #45 Add a test for the `replaceHttpWithHttps` method in `PomModifierTest.java`. * Add a new test method `testReplaceHttpWithHttps` to test the `replaceHttpWithHttps` method. * Initialize `PomModifier` with `OUTPUT_POM_PATH` in the new test method. * Call `replaceHttpWithHttps` method in the new test method. * Save the modified POM to `OUTPUT_POM_PATH` in the new test method. * Parse the modified POM and assert that all `http` URLs are replaced with `https`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/gounthar/plugin-modernizer-tool/issues/45?shareId=XXXX-XXXX-XXXX-XXXX).
jonesbusy
approved these changes
Oct 18, 2024
jonesbusy
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walkthrough
The changes involve updates to the
PreconditionErrorenum, specifically enhancing theMAVEN_REPOSITORIES_HTTPconstant with a remediation function that replaces HTTP URLs with HTTPS in the plugin'spom.xml. A new methodreplaceHttpWithHttps()has been added to thePomModifierclass to facilitate this. Additionally, theMetadataCollectorTestclass has been modified to include a test for this new functionality, ensuring that HTTP URLs are correctly converted to HTTPS in the POM file.Changes
plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/model/PreconditionError.javaMAVEN_REPOSITORIES_HTTPconstant with a remediation function for HTTP to HTTPS conversion.plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/utils/PomModifier.javareplaceHttpWithHttps()method to replace HTTP URLs with HTTPS in XML documents.Assessment against linked issues
Testing done
Submitter checklist