Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ubuntu-12.04.5 amd and i386 templates #1095

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gkumar48
Copy link

@gkumar48 gkumar48 commented Apr 9, 2016

Added new ubuntu-12.04.5 amd and i386 templates.

Old iso files are not available any more.

@mpapis
Copy link
Collaborator

mpapis commented Apr 9, 2016

any chance you could merge them like it's done here: https://github.com/gkumar48/veewee/blob/ubuntu-12.04.5/templates/CentOS-5.10/definition.rb?

@gkumar48
Copy link
Author

I have made the changed as per your suggestions.

@mpapis
Copy link
Collaborator

mpapis commented Apr 12, 2016

now you could merge those two directories into one! in fact you could even merge previous versions too! all into one directory for ubuntu-12.04 :) the biggest benefit of the yml files is that it's easy to compose multiple configurations that have a lot of repeating parts :)

@gkumar48
Copy link
Author

I don't see the merge pull request, it looks like I don't have write access to the repo. Is it possible for you to do the merge?

@mpapis
Copy link
Collaborator

mpapis commented Apr 13, 2016

yes, only maintainers can merge pull requests, as I wrote in previous comment it would be the best if you merged the two directories, the work is not done, it can be improved a lot.

@gkumar48
Copy link
Author

I will try to find sometime and do it this weekend. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants