Nash tech open university wip375491 (PoetOS#432)

* Questionnaire: 'Start page' - replace current links with buttons so consistent with rest of Moodle * PR346 Making buttons exist horizontally. * Changing Behat tests for lang string changes and fixing CI errors. Co-authored-by: Truong Viet <[email protected]>
jcorel · Oct 24, 2022 · faeba26 · faeba26
1 parent ab3cc38
commit faeba26
Show file tree

Hide file tree

Showing 41 changed files with 75 additions and 95 deletions.
diff --git a/backup/moodle1/lib.php b/backup/moodle1/lib.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Choice conversion handler
  */

diff --git a/backup/moodle2/backup_questionnaire_settingslib.php b/backup/moodle2/backup_questionnaire_settingslib.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
  // This activity has no particular settings but the inherited from the generic
  // backup_activity_task so here there isn't any class definition, like the ones
  // existing in /backup/moodle2/backup_settingslib.php (activities section).
diff --git a/backup/moodle2/backup_questionnaire_stepslib.php b/backup/moodle2/backup_questionnaire_stepslib.php
@@ -14,8 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Define all the backup steps that will be used by the backup_questionnaire_activity_task.
  *

diff --git a/backup/moodle2/restore_questionnaire_stepslib.php b/backup/moodle2/restore_questionnaire_stepslib.php
@@ -14,8 +14,6 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Define all the restore steps that will be used by the restore_questionnaire_activity_task.
  *

diff --git a/classes/db/bulk_sql_config.php b/classes/db/bulk_sql_config.php
@@ -16,8 +16,6 @@
 
 namespace mod_questionnaire\db;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * For bulk sql operations on useresponses.
  *

diff --git a/classes/event/all_responses_deleted.php b/classes/event/all_responses_deleted.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire all responses deleted event class.
  *

diff --git a/classes/event/all_responses_saved_as_text.php b/classes/event/all_responses_saved_as_text.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire all_responses_saved_as_text event class.
  *

diff --git a/classes/event/all_responses_viewed.php b/classes/event/all_responses_viewed.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire all_responses_viewed event class.
  *

diff --git a/classes/event/attempt_resumed.php b/classes/event/attempt_resumed.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire attempt_resumed event.
  *

diff --git a/classes/event/attempt_saved.php b/classes/event/attempt_saved.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire attempt_saved event class.
  *

diff --git a/classes/event/attempt_submitted.php b/classes/event/attempt_submitted.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire attempt_submitted event class.
  *

diff --git a/classes/event/course_module_instance_list_viewed.php b/classes/event/course_module_instance_list_viewed.php
@@ -24,7 +24,6 @@
  */
 
 namespace mod_questionnaire\event;
-defined('MOODLE_INTERNAL') || die();
 
 /**
  * The mod_questionnaire instance list viewed event class.

diff --git a/classes/event/course_module_viewed.php b/classes/event/course_module_viewed.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_survery course module viewed event class.
  *

diff --git a/classes/event/non_respondents_viewed.php b/classes/event/non_respondents_viewed.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire non_respondents_viewed event class.
  *

diff --git a/classes/event/questionnaire_previewed.php b/classes/event/questionnaire_previewed.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire questionnaire_previewed event class.
  *

diff --git a/classes/event/response_deleted.php b/classes/event/response_deleted.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire response_deleted event class.
  *

diff --git a/classes/event/response_viewed.php b/classes/event/response_viewed.php
@@ -24,8 +24,6 @@
 
 namespace mod_questionnaire\event;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The mod_questionnaire response_viewed event class.
  *

diff --git a/classes/question/essay.php b/classes/question/essay.php
@@ -93,11 +93,11 @@ protected function question_survey_display($response, $descendantsdata, $blankqu
             $editor = editors_get_preferred_editor();
             $editor->use_editor($name, questionnaire_get_editor_options($this->context));
             $texteditor = html_writer::tag('textarea', $value,
-                            array('id' => $name, 'name' => $name, 'rows' => $rows, 'cols' => $cols, 'class'=>'form-control'));
+                            ['id' => $name, 'name' => $name, 'rows' => $rows, 'cols' => $cols, 'class' => 'form-control']);
         } else {
             $editor = FORMAT_PLAIN;
             $texteditor = html_writer::tag('textarea', $value,
-                            array('id' => $name, 'name' => $name, 'rows' => $rows, 'cols' => $cols));
+                            ['id' => $name, 'name' => $name, 'rows' => $rows, 'cols' => $cols]);
         }
         $output .= $texteditor;
 
@@ -131,9 +131,9 @@ protected function response_survey_display($response) {
      * @param string $helptext
      */
     protected function form_length(\MoodleQuickForm $mform, $helptext = '') {
-        $responseformats = array(
+        $responseformats = [
                         "0" => get_string('formateditor', 'questionnaire'),
-                        "1" => get_string('formatplain', 'questionnaire'));
+                        "1" => get_string('formatplain', 'questionnaire')];
         $mform->addElement('select', 'precise', get_string('responseformat', 'questionnaire'), $responseformats);
         $mform->setType('precise', PARAM_INT);
         return $mform;
@@ -153,7 +153,7 @@ public function supports_mobile() {
      * @param string $helptext
      */
     protected function form_precise(\MoodleQuickForm $mform, $helptext = '') {
-        $choices = array();
+        $choices = [];
         for ($lines = 5; $lines <= 40; $lines += 5) {
             $choices[$lines] = get_string('nlines', 'questionnaire', $lines);
         }

diff --git a/classes/search/activity.php b/classes/search/activity.php
@@ -25,8 +25,6 @@
 
 namespace mod_questionnaire\search;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Search area for mod_questionnaire activities.
  *

diff --git a/db/install.php b/db/install.php
@@ -22,7 +22,6 @@
  * @copyright  2016 Mike Churchward ([email protected])
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-defined('MOODLE_INTERNAL') || die();
 
 /**
  * The install function.

diff --git a/db/upgrade.php b/db/upgrade.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The module upgrade function.
  * @param int $oldversion

diff --git a/drawchart.php b/drawchart.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * This is the function.
  * @param string $feedbacktype

diff --git a/lang/en/questionnaire.php b/lang/en/questionnaire.php
@@ -632,7 +632,7 @@
 $string['usetemplate'] = 'Use template';
 $string['vertical'] = 'Vertical';
 $string['view'] = 'View';
-$string['viewallresponses'] = 'View All Responses';
+$string['viewallresponses'] = 'View all responses';
 $string['viewallresponses_help'] = 'If the questionnaire is set to **Group Mode**: *Visible groups*, or is set to *Separate groups* and the current user
  has the *moodle/site:accessallgroups* capability (in the current context), and groups have been defined in the current course,
  then the user has access to a dropdown list of groups. This dropdown list enables the user to "filter" the questionnaire responses by groups.
@@ -643,7 +643,7 @@
 $string['viewindividualresponse'] = 'Individual responses';
 $string['viewindividualresponse_help'] = 'Click on the respondents\' names in the list below to view their individual responses.';
 $string['viewresponses'] = 'All responses ({$a})';
-$string['viewyourresponses'] = 'Your responses- view {$a}';
+$string['viewyourresponses'] = 'View your response(s)';
 $string['warning'] = 'Warning, error encountered.';
 $string['wronganswers'] = 'There is something wrong with your answers (see below)';
 $string['wrongdateformat'] = 'The date entered: <strong>{$a}</strong> does not correspond to the format shown in the example.';
@@ -652,6 +652,6 @@
 $string['wrongformats'] = 'There is something wrong with your answer to questions:&nbsp;';
 $string['yesno'] = 'Yes/No';
 $string['yesno_help'] = 'Simple Yes/No question.';
-$string['yourresponse'] = 'Your response';
-$string['yourresponses'] = 'Your responses';
+$string['yourresponse'] = 'View your response(s)';
+$string['yourresponses'] = 'View your response(s)';
 $string['crontask'] = 'Questionnaire cleanup job';
diff --git a/questionnaire.class.php b/questionnaire.class.php
@@ -3994,9 +3994,19 @@ public function response_analysis($rid, $resps, $compare, $isgroupmember, $allre
         }
 
         if ($usergraph && $this->survey->chart_type) {
-            $this->page->add_to_page('feedbackcharts',
-                draw_chart($feedbacktype = 'sections', array_values($chartlabels), $groupname,
-                    $allresponses, $this->survey->chart_type, array_values($scorepercent), array_values($allscorepercent), $sectionlabel));
+            $this->page->add_to_page(
+                'feedbackcharts',
+                draw_chart(
+                    'sections',
+                    array_values($chartlabels),
+                    $groupname,
+                    $allresponses,
+                    $this->survey->chart_type,
+                    array_values($scorepercent),
+                    array_values($allscorepercent),
+                    $sectionlabel
+                )
+            );
         }
         if ($this->survey->feedbackscores) {
             $this->page->add_to_page('feedbackscores', html_writer::table($table));

diff --git a/styles.css b/styles.css
@@ -397,6 +397,17 @@ td.selected {
     margin-left: 20px;
 }
 
+.mod_questionnaire_flex-container {
+    display: inline-flex;
+}
+
+#page-mod-questionnaire-view .mod_questionnaire_viewpage div.complete,
+#page-mod-questionnaire-view .mod_questionnaire_viewpage div.yourresponse,
+#page-mod-questionnaire-view .mod_questionnaire_viewpage div.allresponses {
+    flex-grow: 1;
+    margin-right: 10px;
+}
+
 #page-mod-questionnaire-questions #fitem_id_allchoices #id_allchoices,
 #page-mod-questionnaire-questions #fitem_id_allnameddegrees #id_allnameddegrees {
     resize: both;

diff --git a/templates/viewpage.mustache b/templates/viewpage.mustache
@@ -49,8 +49,10 @@
     <h2>{{questionnairename}}</h2>
     {{#intro}}<div class="intro">{{{intro}}}</div>{{/intro}}
     {{#message}}<div class="message">{{{message}}}</div>{{/message}}
-    {{#complete}}<div class="complete">{{{complete}}}</div>{{/complete}}
-    {{#guestuser}}<div class="guestuser">{{{guestuser}}}</div>{{/guestuser}}
-    {{#yourresponse}}<div class="yourresponse">{{{yourresponse}}}</div>{{/yourresponse}}
-    {{#allresponses}}<div class="allresponses">{{{allresponses}}}</div>{{/allresponses}}
+    <div class="mod_questionnaire_flex-container">
+        {{#complete}}<div class="complete">{{{complete}}}</div>{{/complete}}
+        {{#guestuser}}<div class="guestuser">{{{guestuser}}}</div>{{/guestuser}}
+        {{#yourresponse}}<div class="yourresponse">{{{yourresponse}}}</div>{{/yourresponse}}
+        {{#allresponses}}<div class="allresponses">{{{allresponses}}}</div>{{/allresponses}}
+    </div>
 </div>
diff --git a/tests/behat/add_feedback.feature b/tests/behat/add_feedback.feature
@@ -87,7 +87,7 @@ Feature: In questionnaire, personality tests can be constructed using feedback o
     And I press "Submit questionnaire"
     Then I should see "Thank you for completing this Questionnaire."
     And I press "Continue"
-    Then I should see "Your response"
+    Then I should see "View your response(s)"
     And I should see "These are the main Feedback notes"
     And I should see "Global feedback label"
     And I should see "76%"
@@ -110,7 +110,7 @@ Feature: In questionnaire, personality tests can be constructed using feedback o
     And I press "Submit questionnaire"
     Then I should see "Thank you for completing this Questionnaire."
     And I press "Continue"
-    Then I should see "Your response"
+    Then I should see "View your response(s)"
     And I should see "These are the main Feedback notes"
     And I should see "Global feedback label"
     And I should see "44%"

diff --git a/tests/behat/add_multi_feedback_with_sections.feature b/tests/behat/add_multi_feedback_with_sections.feature
@@ -129,7 +129,7 @@ Feature: In questionnaire, personality tests can be constructed using feedback o
     And I press "Submit questionnaire"
     Then I should see "Thank you for completing this Questionnaire."
     And I press "Continue"
-    Then I should see "Your response"
+    Then I should see "View your response(s)"
     And I should see "These are the main Feedback notes"
     And I should see "Section 1 label"
     And I should see "39%"

diff --git a/tests/behat/anonymous_questionnaire.feature b/tests/behat/anonymous_questionnaire.feature
@@ -41,6 +41,6 @@ Feature: Questionnaires can be anonymous
     And I press "Submit questionnaire"
     Then I should see "Thank you for completing this Questionnaire."
     And I press "Continue"
-    Then I should see "Your response"
+    Then I should see "View your response(s)"
     And I should see "Anonymous questionnaire"
     And I should see "Respondent: - Anonymous -"
diff --git a/tests/behat/check_responses.feature b/tests/behat/check_responses.feature
@@ -32,19 +32,19 @@ Feature: Review responses
     And I log in as "teacher1"
     And I am on "Course 1" course homepage
     And I follow "Test questionnaire"
-    Then I should see "View All Responses"
-    And I navigate to "View All Responses" in current page administration
-    Then I should see "View All Responses."
+    Then I should see "View all responses"
+    And I navigate to "View all responses" in current page administration
+    Then I should see "View all responses."
     And I should see "All participants."
     And I should see "View Default order"
     And I should see "Responses: 6"
     And I follow "Ascending order"
-    Then I should see "View All Responses."
+    Then I should see "View all responses."
     And I should see "All participants."
     And I should see "Ascending order"
     And I should see "Responses: 6"
     And I follow "Descending order"
-    Then I should see "View All Responses."
+    Then I should see "View all responses."
     And I should see "All participants."
     And I should see "Descending order"
     And I should see "Responses: 6"
@@ -71,12 +71,12 @@ Feature: Review responses
     And I follow "Admin User"
     Then I should see "1 / 5"
     And I follow "Summary"
-    Then I should see "View All Responses."
+    Then I should see "View all responses."
     And I should see "All participants."
     And I should see "View Default order"
     And I should see "Responses: 5"
     And I follow "Delete ALL Responses"
     Then I should see "Are you sure you want to delete ALL the responses in this questionnaire?"
     And I press "Delete"
     Then I should see "You are not eligible to take this questionnaire."
-    And I should not see "View All Responses"
+    And I should not see "View all responses"
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,8 +22,6 @@ @@
      * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
      */
-    defined('MOODLE_INTERNAL') || die();
     /**
      * Choice conversion handler
      */
@@ Expand Down @@