Skip to content

Commit

Permalink
GEODE-8899: Temporarily restore dunitParallelForks (apache#6335)
Browse files Browse the repository at this point in the history
In my earlier commit to upgrade Gradle to v6.8.3, I inadvertently
removed the `-PdunitParallelForks` option from the build and test CI
scripts.

Some PRs do not yet include the Gradle upgrade. Without this option, the
Dockerized tests for those those PRs use only 8 test workers. Those
test tasks will likely time out.

The CI scripts must continue to specify `-PdunitParallelForks=<N>` until
all PRs include the Gradle upgrade.

Authored-by: Dale Emery <[email protected]>
  • Loading branch information
demery-pivotal authored Apr 16, 2021
1 parent 4636f29 commit e65228f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion ci/scripts/execute_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,14 @@ scp ${SSH_OPTIONS} ${SCRIPTDIR}/capture-call-stacks.sh geode@${INSTANCE_IP_ADDRE
if [[ -n "${PARALLEL_DUNIT}" && "${PARALLEL_DUNIT}" == "true" ]]; then
PARALLEL_DUNIT="-PparallelDunit -PdunitDockerUser=geode"
if [ -n "${DUNIT_PARALLEL_FORKS}" ]; then
DUNIT_PARALLEL_FORKS="--max-workers=${DUNIT_PARALLEL_FORKS} -PtestMaxParallelForks=${DUNIT_PARALLEL_FORKS}"
DUNIT_PARALLEL_FORKS="--max-workers=${DUNIT_PARALLEL_FORKS} -PtestMaxParallelForks=${DUNIT_PARALLEL_FORKS} -PdunitParallelForks=${DUNIT_PARALLEL_FORKS}"
fi
else
PARALLEL_DUNIT=""
DUNIT_PARALLEL_FORKS=""
fi


# SET_JAVA_HOME="export JAVA_HOME=/usr/lib/jvm/java-${JAVA_BUILD_VERSION}-openjdk-amd64"
SET_JAVA_HOME="export JAVA_HOME=/usr/lib/jvm/bellsoft-java${JAVA_BUILD_VERSION}-amd64"

Expand Down
2 changes: 1 addition & 1 deletion ci/scripts/execute_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ scp ${SSH_OPTIONS} ${SCRIPTDIR}/capture-call-stacks.sh geode@${INSTANCE_IP_ADDRE
if [[ -n "${PARALLEL_DUNIT}" && "${PARALLEL_DUNIT}" == "true" ]]; then
PARALLEL_DUNIT="-PparallelDunit -PdunitDockerUser=geode -PdunitDockerImage=\$(docker images --format '{{.Repository}}:{{.Tag}}')"
if [ -n "${DUNIT_PARALLEL_FORKS}" ]; then
DUNIT_PARALLEL_FORKS="--max-workers=${DUNIT_PARALLEL_FORKS} -PtestMaxParallelForks=${DUNIT_PARALLEL_FORKS}"
DUNIT_PARALLEL_FORKS="--max-workers=${DUNIT_PARALLEL_FORKS} -PtestMaxParallelForks=${DUNIT_PARALLEL_FORKS} -PdunitParallelForks=${DUNIT_PARALLEL_FORKS}"
fi
else
PARALLEL_DUNIT=""
Expand Down

0 comments on commit e65228f

Please sign in to comment.