Fix crash in XAML design mode #7
Conversation
| _windowInfo = Utilities.CreateWindowsWindowInfo( | ||
| new WindowInteropHelper(Window.GetWindow(this)).Handle); | ||
| } | ||
| catch |
There was a problem hiding this comment.
Why is this necessary? Can't you just add a design mode check?
OpenTkControl/OpenTkControlBase.xaml
Outdated
| mc:Ignorable="d" | ||
| d:DesignHeight="300" d:DesignWidth="300"> | ||
| <Image x:Name="Image" Stretch="Fill" RenderTransformOrigin="0.5,0.5"> | ||
| <UserControl |
There was a problem hiding this comment.
Please don't make unnecessary changes. They just clutter git history
There was a problem hiding this comment.
Sorry it has been formatted automatically by VS plugin XAML Fomatter.
OpenTkControl/packages.config
Outdated
| @@ -1,4 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <packages> | |||
| <package id="OpenTK" version="2.0.0" /> | |||
| <package id="OpenTK" version="2.0.0" targetFramework="net45" /> | |||
There was a problem hiding this comment.
this project has been reference by my other projects and VS modify it automatically. fixed
| @@ -305,6 +305,8 @@ public Task RequestRepaint() | |||
| return tcs.Task; | |||
| } | |||
|
|
|||
| protected bool IsDesignMode => DesignerProperties.GetIsInDesignMode(this); | |||
There was a problem hiding this comment.
I think inlining this would be more clear
|
In fact I notice glReadPixels spend most time on copying buffer into bitmap though CPU. I think it could use WGL_NV_DX_interop and share with DirectX surface. |
|
The changes look great. I just want to test them before I approve and I probably won't have time until the weekend. You're right that the current CPU copying method isn't efficient and that interop function looks like it could really improve things. I didn't know it existed. I'm not actively developing this library any more, but you're welcome to integrate and PR it if you want. |
|
OK I had implemented this opengl extension and release a example. I will take a test and format code before raising new PR. But this is temporary solution because the team of OpenTK dev also want to improve their control library though this extension and WGL_NV_DX_interop2. |
Fix issue : #6
and another bug when control want to generate a opengl buffer in design mode: