Add tests of scalar type behavior #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_719426592
branch
8 times, most recently
from
42fc0cb to
48474ce
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_719426592
branch
3 times, most recently
from
79c477a to
bcdad12
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_719426592
branch
2 times, most recently
from
134eeb6 to
f155435
Compare
This began as an experiment in making scalar types derive from higher up in the NumPy scalar type hierarchy (e.g. np.number), but this led to downstream errors. I backed-off on that change for now, but these tests are designed to catch the resulting problems more quickly. PiperOrigin-RevId: 720754117
copybara-service
bot
force-pushed
the
test_719426592
branch
from
f155435 to
ad2580b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests of scalar type behavior
This began as an experiment in making scalar types derive from higher up in the NumPy scalar type hierarchy (e.g. np.number), but this led to downstream errors. I backed-off on that change for now, but these tests are designed to catch the resulting problems more quickly.