Extend random.orthogonal to semi-orthogonal matrices and simplify initializers.orthogonal
#26291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakevdp
reviewed
Feb 4, 2025
carlosgmartin
force-pushed
the
simplify_nn_initializers_orthogonal
branch
from
84fcfbe to
c47b476
Compare
|
@jakevdp Updated. |
jakevdp
approved these changes
Feb 4, 2025
google-ml-butler
bot
added
kokoro:force-run
pull ready
|
Looks like there are some type checking errors – you may have to rename |
carlosgmartin
force-pushed
the
simplify_nn_initializers_orthogonal
branch
from
c47b476 to
bfb0c6b
Compare
|
@jakevdp Fixed. |
…lizers.orthogonal by using it.
carlosgmartin
force-pushed
the
simplify_nn_initializers_orthogonal
branch
from
bfb0c6b to
3bca112
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
random.orthogonalto semi-orthogonal matrices.initializers.orthogonalby using this new functionality.