countries sorted by cases for api get all countries #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! First of all thanks! The problem I see here is, it is sorting every single time there is a request (300 requests/second are reaching the host at the moment). What if we do the sorting right before saving it to db? that we will already be sorted when fetching it and only happens once every 3 minutes... |
|
Thats a good idea should be fine. |
|
The web scraping part i don't know . You used cheerio manipulating the data? The table there is already sorted i think. |
|
Seems like the only one out of place is china isnt it? maybe we should just investigate why |
|
Yes can you sort before insert to db? |
|
I think we should sort in the api get itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.