chore: fix some struct names in comment #6509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: longxiangqiao <[email protected]>
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6509 +/- ##
==========================================
+ Coverage 96.26% 96.29% +0.02%
==========================================
Files 372 372
Lines 21282 21282
==========================================
+ Hits 20488 20493 +5
+ Misses 607 603 -4
+ Partials 187 186 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
added
the
changelog:skip
|
we cannot merge from main branch of a fork |
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Jan 9, 2025
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves #123 --> ## Description of the changes fix some struct names in comment resubmit for #6253 and #6509 ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: longxiangqiao <[email protected]>
mahadzaryab1
pushed a commit
to mahadzaryab1/jaeger
that referenced
this pull request
Jan 11, 2025
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> ## Description of the changes fix some struct names in comment resubmit for jaegertracing#6253 and jaegertracing#6509 ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: longxiangqiao <[email protected]>
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this pull request
Jan 14, 2025
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - <!-- Example: Resolves jaegertracing#123 --> ## Description of the changes fix some struct names in comment resubmit for jaegertracing#6253 and jaegertracing#6509 ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: longxiangqiao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
fix some struct names in comment
resubmit for #6253
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test