Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logzio storage plugin #344

Merged
merged 3 commits into from
Dec 29, 2019

Conversation

yyyogev
Copy link
Contributor

@yyyogev yyyogev commented Dec 26, 2019

Which problem is this PR solving?

Missing new storage plugin - logz.io

Short description of the changes

Add a link to jaeger-logzio repo

@@ -398,6 +398,7 @@ Jaeger supports gRPC based storage plugins. For more information refer to [jaege

Available plugins:

* [Logz.io](https://github.com/logzio/jaeger-logzio)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please move into second place
  • this is not an open-source backend, correct? Please clarify that this is commercially hosted storage

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yurishkuro is this clear enough?

@@ -27,7 +27,7 @@ Jaeger backend, Web UI, and instrumentation libraries have been designed from gr
## Multiple storage backends

Jaeger supports two popular open source NoSQL databases as trace storage backends: Cassandra 3.4+ and Elasticsearch 5.x/6.x/7.x.
There are ongoing community experiments using other databases, such as ScyllaDB, InfluxDB, Amazon DynamoDB. Jaeger also ships
There are ongoing community experiments using other databases, such as Logz.io ,ScyllaDB, InfluxDB, Amazon DynamoDB. Jaeger also ships
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There are ongoing community experiments using other databases, such as Logz.io ,ScyllaDB, InfluxDB, Amazon DynamoDB. Jaeger also ships
There are ongoing community experiments using other databases, such as ScyllaDB, InfluxDB, Amazon DynamoDB, Logz.io. Jaeger also ships

@@ -399,6 +399,7 @@ Jaeger supports gRPC based storage plugins. For more information refer to [jaege
Available plugins:

* [InfluxDB](https://github.com/influxdata/jaeger-influxdb/)
* [Logz.io](https://github.com/logzio/jaeger-logzio) - Secure & Scalable Log Management with Cloud-Based ELK.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Logz.io](https://github.com/logzio/jaeger-logzio) - Secure & Scalable Log Management with Cloud-Based ELK.
* [Logz.io](https://github.com/logzio/jaeger-logzio) - secure, scalable, managed, cloud-based ELK storage.

Signed-off-by: yyyogev <[email protected]>
@yurishkuro yurishkuro merged commit 28ecc9a into jaegertracing:master Dec 29, 2019
@yyyogev
Copy link
Contributor Author

yyyogev commented Dec 29, 2019

@yurishkuro Thanks a lot!
We'd really appreciate it if you will also add it in the storages thread

@yurishkuro
Copy link
Member

done

@yyyogev yyyogev deleted the add-logzio-storage-plugin branch December 29, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants