minor update

jabrena · May 31, 2024 · 64b62c8 · 64b62c8
1 parent 09696f2
commit 64b62c8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 12 deletions.
diff --git a/training/src/main/java/info/jab/fp/sealed/AgeProblemExample.java b/training/src/main/java/info/jab/fp/sealed/AgeProblemExample.java
@@ -3,11 +3,6 @@
 public class AgeProblemExample {
 
     record Age(Integer age) {}
-
-    // these are the potential problems
-    sealed interface AgeProblem permits InvalidAge, NotLegalAdult {
-        String getMessage();
-    }
 
     record InvalidAge() implements AgeProblem {
 
@@ -25,11 +20,13 @@ public String getMessage() {
         }
     }
 
-    //Either<AgeProblem, Age> problem1 = Either.left(new InvalidAge());
-    //Either<AgeProblem, Age> problem2 = Either.left(new NotLegalAdult());
-    //Either<AgeProblem, Age> success = Either.right(new Age(20));
+    // these are the potential problems
+    sealed interface AgeProblem permits InvalidAge, NotLegalAdult {
+        String getMessage();
+    }
 
-    public Either<AgeProblem, Age> validateAge(Integer age) {
+    // validation returns either problems or the constructed value
+    public Either<AgeProblem, Age> validatAge(Integer age) {
         return switch (age) {
             case Integer a when a < 0 -> Either.left(new InvalidAge());
             case Integer a when a < 18 -> Either.left(new NotLegalAdult());

diff --git a/training/src/test/java/info/jab/fp/sealed/AgeProblemExampleTest.java b/training/src/test/java/info/jab/fp/sealed/AgeProblemExampleTest.java
@@ -18,12 +18,12 @@ public void should_notValidate() {
 
         AgeProblemExample example = new AgeProblemExample();
 
-        var result = example.validateAge(-1);
+        var result = example.validatAge(-1);
 
         assertThat(result).isInstanceOf(Either.class);
         assertThat(result.isLeft()).isTrue();
 
-        var result2 = example.validateAge(17);
+        var result2 = example.validatAge(17);
         assertThat(result2).isInstanceOf(Either.class);
         assertThat(result2.isLeft()).isTrue();
 
@@ -45,7 +45,7 @@ public void should_validate() {
 
         AgeProblemExample example = new AgeProblemExample();
 
-        var result = example.validateAge(18);
+        var result = example.validatAge(18);
 
         assertThat(result).isInstanceOf(Either.class);
         assertThat(result.isRight()).isTrue();