-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inv_sig_helper pod #9
base: master
Are you sure you want to change the base?
Conversation
I'm not sure if sighelper shouldn't be separate pod. Let me think a bit ;) |
Both are correct solution. If in the same container, you can benefit from the high speed socket file provided by inv_sig_helper. And the other solution in a separate pod, you can have multiple invidious pods using one single inv_sig_helper. Do note that in this case it's not a good idea to have multiple inv_sig_helper and will lead to decryption issues. I'm more leaning towards the second option because if one is using kubernetes then it's to scale "invidious" and not to keep it at just one replica. |
This reverts commit d3cef4d.
So you'd prefer to have multiple pods, right? |
So I think inv_sig_helper should be in separate StatefulSet then. |
Why a statefulset? It doesn't story any data. |
It does hold the state.
|
I'm not updating the chart version anymore — that's your thing as maintainer(s) of the chart to decide whether/how/when to update it. |
We appreciate people that also modify the Chart.yaml though. It's a community helm chart everyone contribute it, not only the maintainers :). If you can set it to 2.1.0 that would be great because this is a minor change. And change the app version to the invidious changelog. Thakks |
Added sidecar container with inv_sig_helper (fixes #5)