Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary semicolon which breaks zsh on mac #16185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

craigbox
Copy link
Contributor

zsh, in many default configurations, escapes special characters on paste. The ; in the Gateway API example is replaced with \; which causes the command to fail.

As it's not a load-bearing semi-colon, lets just remove it.

Fixes #16162

@craigbox craigbox requested review from a team as code owners January 20, 2025 08:40
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2025
@craigbox
Copy link
Contributor Author

you're kidding me. it is a load bearing semi-colon?

@craigbox
Copy link
Contributor Author

Now we don't use kustomize should I just nuke the braces?

@kfaseela
Copy link
Member

saw the lint failure only after approving :D

@craigbox
Copy link
Contributor Author

note to self, make Faseela an approver for Ukranian too

@istio-testing
Copy link
Contributor

@craigbox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 6681b2c link true /test lint
doc.test.profile-ambient_istio.io 6681b2c link true /test doc.test.profile-ambient
doc.test.profile-demo_istio.io 6681b2c link true /test doc.test.profile-demo
doc.test.profile-none_istio.io 6681b2c link true /test doc.test.profile-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix our install doc on gw API
3 participants