-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated multi primary multi network docs #534
base: main
Are you sure you want to change the base?
Conversation
|
Hi @jforce. Thanks for your PR. I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -110,6 +110,8 @@ spec: | |||
requests: | |||
cpu: 100m | |||
memory: 1024Mi | |||
env: | |||
ROOT_CA_DIR: /etc/cacerts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We can revert this if/when we fix the default path.
@jforce: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hmm, interesting. The RedHat's build of the pilot image does set
So I'm not sure why it doesn't work in your case. What pilot image are you using, @jforce? |
/hold until we confirm that this is truly needed |
I don't have the cluster I was using to hand now, but I was using OSSM 3.0 TP2 (istio 1.24.1) on OpenShift (so the Red Hat build) |
I was just trying out multi primary multi network by following the documentation here and it wasn't working until I added
spec.values.pilot.env.ROOT_CA_DIR: /etc/cacerts
in theIstio
resource.Without this, I was getting the below error:
It seems like some other versions of the docs specified this too github.com/openshift-service-mesh/sail-operator/pull/144
@