Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Integrate Paddle to ml module #7151

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[Backend] Integrate Paddle to ml module #7151

wants to merge 22 commits into from

Conversation

Woodman3
Copy link

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

This PR is the part I of integration Paddle to ml module.

More details: #7027

We don't integrate Paddle unit test to workflow currently (this will be implement at part II). So we provide a method to build from source to reproduce our works.

Environment

image：registry.baidubce.com/paddlepaddle/paddle:3.0.0b1-gpu-cuda11.8-cudnn8.6-trt8.5

NOTE: we not verify other environment currently.

How to build

  1. update cmake
wget -nc https://paddle-org.bj.bcebos.com/paddlescience/cmake-3.23.0-linux-x86_64.tar.gz
tar -zxvf cmake-3.23.0-linux-x86_64.tar.gz
rm -f cmake-3.23.0-linux-x86_64.tar.gz
PATH=$PWD/cmake-3.23.0-linux-x86_64/bin:$PATH
  1. Install dependencies
util/install_deps_ubuntu.sh
pip install yapf==0.30.0
  1. Install nightly-build paddlepaddle-gpu
pip uninstall paddlepaddle-gpu
python -m pip install --pre paddlepaddle-gpu -i https://www.paddlepaddle.org.cn/packages/nightly/cu118/
  1. Config
mkdir build
cd build
cmake  -DBUILD_CUDA_MODULE=ON \
             -DBUILD_PADDLE_OPS=ON  \
             -DBUNDLE_OPEN3D_ML=OFF \
             ..
  1. Build
make -j8
  1. Install
make install-pip-package
  1. Verify
python -c "import open3d.ml.paddle"
···

SecretXV and others added 18 commits November 5, 2024 11:48
@SecretXV
[DOC] initial commit
e1b6116 
Signed-off-by: SecretXV <[email protected]>
@SecretXV
[CodeStyle] Add pre-commit config
331ec7f
@SecretXV
[Feat] Integrate Paddle to ml module (isl-org#1)
58b3105 
* [Feat] Integrate Paddle to ml module

Signed-off-by: SecretXV <[email protected]>

* CI retrigger

Signed-off-by: SecretXV <[email protected]>

---------

Signed-off-by: SecretXV <[email protected]>
@SecretXV
[Fix] remove useless files
86848ab 
Signed-off-by: SecretXV <[email protected]>
@SecretXV
[Fix] fix compile on gcc 8.2.0 (isl-org#4)
cd5510b 
Signed-off-by: SecretXV <[email protected]>
@Woodman3 @SecretXV
[Feat] Add all misc operators (isl-org#3)
501af0e 
* [Feat]  Add all misc operators

* add comment to cpp/open3d/ml/paddle/misc/VoxelizeOpKernel.cu

* [CodeStyle] device to place

---------

Signed-off-by: Woodman3 <[email protected]>
Signed-off-by: RDIO <[email protected]>
Co-authored-by: SecretXV <[email protected]>
@Woodman3
[Feat] Add pointnet operators (isl-org#5)
75cbc86 
* add pointnet op

* [Fix] Delete scripts directory

---------

Signed-off-by: Woodman3 <[email protected]>
Signed-off-by: RDIO <[email protected]>
@Woodman3
[Feat] Add ContinuousConv and ContinuousConvTranspose operators (isl-…
f1ab64c 
…org#6)

* [Feat] add conv op

* [Doc] add comment

* [fix] add contigous(not compile)

---------

Signed-off-by: Woodman3 <[email protected]>
@Woodman3
[Feat] Add SparseConv and SparseConvTranspose operators (isl-org#7)
fea60e9 
* [Feat] add sconv_op

* [Fix] include sstream

* [doc] add comment

---------

Signed-off-by: Woodman3 <[email protected]>
@Woodman3
[Doc] Add doc about paddle backend
f824dc2 
* [doc] add rst doc

* [doc] add install commend

* [doc] update install guide

* [doc] add doc generate code

* [doc] delete verify

* [fix] add requirment as upstream

* [doc] make install guide as reference

---------

Signed-off-by: Woodman3 <[email protected]>
@SecretXV
[CI] support paddle ci (isl-org#10)
90462b6 
* [CI] support paddle ci

* fix

* fix
@SecretXV
Revert "[CI] support paddle ci (isl-org#10)" (isl-org#11)
a87bb30 
This reverts commit 90462b6.
@SecretXV
[CI] support paddle ci (isl-org#12)
22ef23e
@SecretXV
[Doc] Fix doc generate (isl-org#13)
2e3b186 
* [Doc] fix docs

* fix

---------

Signed-off-by: SecretXV <[email protected]>
@SecretXV
[CodeStyle] update license year from 2023 to 2024 (isl-org#14)
6b19203 
Signed-off-by: SecretXV <[email protected]>
@Woodman3 @SecretXV
[BUILD] remove version restriction (isl-org#15)
18e3b6e 
Co-authored-by: SecretXV <[email protected]>
@Woodman3
Merge branch 'paddle' into main
2cf0489
@Woodman3
sycn with up-stream
caa6d8c
@update-docs Update Docs
Copy link

update-docs bot commented Jan 28, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

BeingGod
BeingGod reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@BeingGod BeingGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some questions. Please take a look.

util/run_python_unittest.sh Outdated Show resolved Hide resolved
docs/_static/paddle_logo.png Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
cpp/open3d/visualization/visualizer/O3DVisualizer.cpp Outdated Show resolved Hide resolved
cpp/open3d/visualization/visualizer/GuiVisualizer.cpp Outdated Show resolved Hide resolved
python/LICENSE.txt Outdated Show resolved Hide resolved
python/js/lib/web_visualizer.js Outdated Show resolved Hide resolved
LICENSE Outdated Show resolved Hide resolved
docker/docker_build.sh Outdated Show resolved Hide resolved
@BeingGod
Copy link
Contributor

BeingGod commented Feb 3, 2025

Generally LGTM. Could you help our review this PR ? @ssheorey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeingGod BeingGod BeingGod left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Woodman3 @BeingGod @SecretXV