Merge pull request #2 from ironpeakservices/feat/kubelinter

Feature: add kubelinter
ironpeakservices · Jan 15, 2021 · 6c15dc4 · 6c15dc4
2 parents 7c3395d + fd8352d
commit 6c15dc4
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 11 deletions.
diff --git a/.github/kubelinter.yml b/.github/kubelinter.yml
@@ -0,0 +1 @@
+
diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml
@@ -4,17 +4,25 @@ on: [pull_request]
 
 jobs:
 
-  # k8slint:
-  #   name: Kubernetes
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #   -
-  #     uses: actions/checkout@v2
-  #   -
-  #     uses: makocchi-git/[email protected]
-  #     with:
-  #       files: kubernetes/helm/templates/
-  #       token: ${{ secrets.GITHUB_TOKEN }}
+  k8slint:
+    name: Kubernetes
+    runs-on: ubuntu-latest
+    steps:
+    -
+      uses: actions/checkout@v2
+    -
+      name: Set up Helm
+      uses: azure/setup-helm@v1
+    -
+      name: Compile helm chart
+      run: |
+        mkdir compiled/
+        helm template kubernetes/helm > compiled/all.yaml
+    -
+      uses: stackrox/kube-linter-action@v1
+      with:
+        directory: compiled/
+        config: .github/kubelinter.yml
 
   stylelint:
     name: Styles

diff --git a/kubernetes/helm/templates/deployment.yaml b/kubernetes/helm/templates/deployment.yaml
@@ -79,6 +79,9 @@ spec:
         {{ end }}
 
         resources:
+          requests:
+            cpu: 0.1
+            memory: 50Mi
           limits:
             cpu: 0.5
             memory: 300Mi

diff --git a/kubernetes/helm/templates/tests/service.test.yaml b/kubernetes/helm/templates/tests/service.test.yaml
@@ -34,6 +34,9 @@ spec:
     args:  ['-O/dev/null', '-q', '{{ .Values.name }}:{{ .Values.servicePort }}']
 
     resources:
+      requests:
+        cpu: 0.1
+        memory: 50Mi
       limits:
         cpu: 100m
         memory: 64Mi