Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account-registration: add the informational account-required cap #492

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

emersion
Copy link
Contributor

Alternative to #490.

Closes: ircv3/ircv3-ideas#73

cc @slingamn

@emersion
Copy link
Contributor Author

emersion commented Mar 26, 2022

Here's how my UI looks like. ATM everything is on one screen but I may split the hostname and nickname/password to 2 separate screens in the future.

screenshot

User fills the first field:

screenshot

At this point, my client connects to the server, sends CAP LS, then closes the connection. If authentication is required, the UI changes to this and the form refuses to be submitted if the password is empty:

screenshot

If SASL isn't supported the UI switches to this:

screenshot

(Advanced settings to set the username/realname/server pass/etc will be added in the future, but are missing for now.)

@emersion
Copy link
Contributor Author

emersion commented Apr 6, 2022

@slingamn @kylef @jwheare any thoughts on this PR?

@emersion
Copy link
Contributor Author

Gentle ping

@emersion
Copy link
Contributor Author

@kylef @jwheare Gentle ping

@jwheare
Copy link
Member

jwheare commented Apr 28, 2022

My opinion is unchanged since #490 (comment)

@emersion
Copy link
Contributor Author

Okay. What would it take to merge this?

@emersion
Copy link
Contributor Author

emersion commented Jun 1, 2022

Gentle ping

@ValwareIRC
Copy link
Contributor

FWIW I don't think this is a great idea to add into account-registration, as it assumes that the registration mechanism is in IRC.

My use case: ircv3/ircv3-ideas#89

I would like to be able to advertise account-required without it meaning that the user should try to register over IRC using account-registration. It just doesn't feel like it fits in this spec.

@emersion
Copy link
Contributor Author

emersion commented Jun 4, 2022

it assumes that the registration mechanism is in IRC.

There's no such assumption.


Alright, since there's no positive feedback here, I'll ship this as a vendored cap in soju+goguma.

@progval
Copy link
Contributor

progval commented Jun 4, 2022

I think it's a fine concept to add to IRCv3, I just don't have anything meaningful to contribute to the discussion

emersion added a commit to emersion/soju that referenced this pull request Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a capability indicating mandatory authentication
5 participants