-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add draft/bouncer-networks #478
base: master
Are you sure you want to change the base?
Conversation
iirc there is a written spec for irc:// urls but I don't think it matches the de facto standard |
discussion here: ircdocs/modern-irc#6 |
Well, I think we also don't want to allow all irc:// URLs. We probably only want to allow host/port and irc/ircs, nothing else (no user/password, no target, no query params, etc). Additionally I'm not a fan of allowing irc:// (as opposed to ircs://). irc:// makes it extremely easy for clients to setup plain-text connections. In other words, setting up TLS requires extra effort (paying attention to use the ircs:// variant instead of the widely used irc:// variant). I'd rather have it the other way around (TLS by default, and explicit extra effort needed to setup plain-text connections). |
|
I'd prefer to avoid version checks, and instead use feature detection. ie. enable $feature the bouncer advertises
It depends how many attributes we'll end up with I guess. Sending all the data always may not scale well.
Nack, the current spec uses standard replies. |
It would also be nice to have a way for the bouncer to send a plain-text status message for each network. This would allow clients to show in their UI the reason why a network is disconnected. |
This is based on the vendored soju.im/bouncer-networks extension [1]. [1]: https://git.sr.ht/~emersion/soju/tree/master/item/doc/ext/bouncer-networks.md?view-source
2789b43
to
047a37a
Compare
This is based on the vendored soju.im/bouncer-networks extension.
host
/port
attrsenabled
attrBOUNCER NETWORK b33f -host,-port
)cc @DarthGandalf @ItsOnlyBinary