Skip to content

Commit

Permalink
Merge pull request #39 from ipkpjersi/develop
Browse files Browse the repository at this point in the history
Image download comment improvements
  • Loading branch information
ipkpjersi authored Dec 26, 2024
2 parents 5e6e882 + 93297b8 commit c134924
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/Console/Commands/DownloadAndImportAnimeData.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public function handle(): void

// Download Anime Images
$this->info('Downloading anime images...');
//We could technically force this to re-download all anime images, except with our sleep timers it means it takes a week or more, so let's leave it off for now. The JSON anime database file is what sets the image URLs, which means it will only ever be delta updates (for existing anime), which means we probably don't really need to re-download all images. We could separately track if the anime image changes over time, which it likely will at some point, but this is likely largely unnecessary. It's always possible to start with anime images from scratch by running php artisan app:clear-anime-image-files and php artisan app:clear-anime-image-zip-files then php artisan app:download-anime-images --force to download all anime images from scratch.
//We could technically force this to re-download all anime images, except with our sleep timers it means it takes a week or more, so let's leave it off for now. The JSON anime database file is what sets the image URLs, which means it will only ever be delta updates (for existing anime), which means we probably don't really need to re-download all images, unless so many images have changed over time that we need to clear up storage space by removing images that are now unused. We could separately track if the anime image changes over time, which they likely will at some point, but this is likely largely unnecessary. It's always possible to start with anime images from scratch by running php artisan app:clear-anime-image-files and php artisan app:clear-anime-image-zip-files then php artisan app:download-anime-images --force to download all anime images from scratch.
//Artisan::call('app:download-anime-images', ['--force' => true], new ConsoleOutput);
Artisan::call('app:download-anime-images', [], new ConsoleOutput);

Expand Down

0 comments on commit c134924

Please sign in to comment.