define children explicitly in more places

ionic-team · Jan 3, 2025 · df945f5 · df945f5
1 parent 484f247
commit df945f5
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 0 deletions.
diff --git a/packages/react/src/components/createControllerComponent.tsx b/packages/react/src/components/createControllerComponent.tsx
@@ -10,6 +10,7 @@ interface OverlayBase extends HTMLElement {
 
 export interface ReactControllerProps {
   isOpen: boolean;
+  children?: React.ReactNode;
   onDidDismiss?: (event: CustomEvent<OverlayEventDetail>) => void;
   onDidPresent?: (event: CustomEvent<OverlayEventDetail>) => void;
   onWillDismiss?: (event: CustomEvent<OverlayEventDetail>) => void;

diff --git a/packages/react/src/components/navigation/IonNav.tsx b/packages/react/src/components/navigation/IonNav.tsx
@@ -14,6 +14,7 @@ const IonNavInner = createReactComponent<JSX.IonNav & { delegate: FrameworkDeleg
 );
 
 type IonNavProps = JSX.IonNav & {
+  children?: React.ReactNode;
   forwardedRef?: React.ForwardedRef<HTMLIonNavElement>;
 };
 

diff --git a/packages/react/src/routing/NavManager.tsx b/packages/react/src/routing/NavManager.tsx
@@ -34,6 +34,7 @@ interface NavManagerProps {
   ionRoute: any;
   stackManager: any;
   locationHistory: LocationHistory;
+  children?: React.ReactNode;
 }
 
 export class NavManager extends React.PureComponent<NavManagerProps, NavContextState> {

diff --git a/packages/react/src/routing/PageManager.tsx b/packages/react/src/routing/PageManager.tsx
@@ -8,6 +8,7 @@ import { StackContext } from './StackContext';
 
 interface PageManagerProps {
   className?: string;
+  children?: React.ReactNode;
   forwardedRef?: React.ForwardedRef<HTMLDivElement>;
   routeInfo?: RouteInfo;
 }

diff --git a/packages/react/src/routing/ViewLifeCycleManager.tsx b/packages/react/src/routing/ViewLifeCycleManager.tsx
@@ -5,6 +5,7 @@ import { DefaultIonLifeCycleContext, IonLifeCycleContext } from '../contexts/Ion
 interface ViewTransitionManagerProps {
   removeView: () => void;
   mount: boolean;
+  children?: React.ReactNode;
 }
 
 interface ViewTransitionManagerState {
-Original file line number
+Diff line change
@@ Expand Up @@
     );
     type IonNavProps = JSX.IonNav & {
+      children?: React.ReactNode;
       forwardedRef?: React.ForwardedRef<HTMLIonNavElement>;
     };
@@ Expand Down @@