Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: getRemoteWidgets dont check widgetsets in detail for ignoreInVersions #516

Open
oweitman opened this issue Jan 22, 2025 · 0 comments
Open
Labels
bug 🐞 Something isn't working

Comments

@oweitman
Copy link

oweitman commented Jan 22, 2025

The following line only checks ignoreInVersions only in the first level of common.visWidgets and this is wrong

const ignoreVersions: number[] = (obj.common.visWidgets as any).ignoreInVersions || [];

common.visWidgets can contain multiple widget sets as an Array, each of which optionally can contain the ignoreInVersions attribute

Unfortunately, I can't make a suggestion here, as I'm having trouble debugging Typescript properly in vscode

@oweitman oweitman changed the title getRemoteWidgets dont check widgetsets in detail for ignoreInVersions BUG: getRemoteWidgets dont check widgetsets in detail for ignoreInVersions Jan 22, 2025
@Feuer-sturm Feuer-sturm added the bug 🐞 Something isn't working label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants