Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: check for ignoreInVersions is wrong #515

Closed
oweitman opened this issue Jan 22, 2025 · 1 comment
Closed

BUG: check for ignoreInVersions is wrong #515

oweitman opened this issue Jan 22, 2025 · 1 comment

Comments

@oweitman
Copy link

oweitman commented Jan 22, 2025

The ignoreInVersions check in the readAdapterList function only checks if any widget set is ignored in version 2 of vis.
If you have more than one widget set (one for vis1, one for vis2), the adapter will not take this into account.

Object.values(obj?.common?.visWidgets).find(w => w?.ignoreInVersions?.includes(2))

Object.values(obj?.common?.visWidgets).find(w => w?.ignoreInVersions?.includes(2))

mybe it is better to replace find with every:

Object.values(obj?.common?.visWidgets).every(w => w?.ignoreInVersions?.includes(2))

@oweitman
Copy link
Author

ok, i checked the rest of the code
and this place is not the problem
but please see #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant