Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detection of level.direction #86

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Added detection of level.direction #86

merged 3 commits into from
Jan 15, 2025

Conversation

GermanBluefox
Copy link
Contributor

No description provided.

@GermanBluefox GermanBluefox requested review from Copilot and Apollon77 and removed request for Copilot January 13, 2025 19:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

Files not reviewed (2)
  • LICENSE: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (6)

DEVICES.md:442

  • The regex pattern uses a non-standard character '|' instead of '|'. It should be corrected to /^(indicator|level)\.direction$/.
|   | DIRECTION | level.direction               |      | number  |    |      |     |      | `/^(indicator|level)\.direction$/`                                           |

src/types.ts:2

  • The copyright year has been updated correctly.
 * Copyright 2018-2025 bluefox <[email protected]>

src/types.ts:89

  • Corrected 'write only' to 'write-only' for clarity.
noSubscribe?: boolean; // no automatic subscription for this state (e.g., if write-only)

src/types.ts:90

  • Corrected 'search' to 'searched' for grammatical accuracy.
searchInParent?: boolean; // if this pattern should be searched in a device too and not only in channel

src/types.ts:93

  • Corrected 'in parent device' to 'in a parent device' for grammatical accuracy.
noDeviceDetection?: boolean; // do not search indicators in a parent device

src/types.ts:95

  • Corrected 'is state of indicator must be inverted' to 'if the state of indicator must be inverted' for grammatical accuracy.
inverted?: boolean; // if the state of indicator must be inverted

DEVICES.md Outdated Show resolved Hide resolved
DEVICES.md Outdated Show resolved Hide resolved
DEVICES.md Outdated Show resolved Hide resolved
src/TypePatterns.ts Outdated Show resolved Hide resolved
@Apollon77 Apollon77 merged commit 2b548ea into master Jan 15, 2025
12 checks passed
@Apollon77 Apollon77 deleted the direction-enum branch January 15, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants